Umut CANandClaude Opus 5.5
898e775f93
The evidence for tracks B and G, in the shape tracks A and E used.
- benchmarks/tasks_v5.py: 18 tasks, DEFAULT_MATRIX = "v5"; v4, v3 and v2 stay
addressable so an earlier report reproduces exactly rather than being only
described. mech_assembly is roadmap criterion 3 - a flange-coupling sheet
built from the part model and the sheet standard, through the code the
tools call (apply_titleblock, draw_part/add_view/dimension_part,
insert_std_part, extract_records -> draw_bom_table, add_balloon), gated on
two numbers that cannot be negotiated: drawing_critique(focus=None) returns
zero issues and the finalize score is at least 90 (it scores 100, 18/18 on
the v5 matrix). The adapter returns the focuses that fired, so a
regression names itself, and a test drops one balloon to prove the gate
fails and names mech_bom_balloon_mismatch.
- Seven correctness checks (32 -> 39). mech_section_hatch_area is the one
that cannot be faked: a sleeve of length 60, outside diameter 40 and bore
20 cuts two faces totalling 1200 mm^2 exactly, read back out of the drawing
through entity_measure. sheet_frame_iso5457_a3 pins the A3 frame (20,10 to
410,287 inside the 420 x 297 trimmed sheet); mech_iso286_on_dimension pins
40 H7 at +0.025/0 through the layout; std_part_iso4014_m12 pins s = 18 and
k = 7.5 by value; mech_thread_unrepresented_is_caught is the seventh: a
quality gate that never fires is not a gate.
- scripts/smoke_mech_com.py executed every new COM path once on AutoCAD 2026
(25.1s): frame, title block, a sectioned shaft with 12 dimensions, an ISO
4014 block with 1 ACADMCP_MECH chunk, a weld symbol, the parts list read off
the drawing, a linked balloon, an xref attached / listed / detached, a
31687-byte .dwg (AC1032) through ActiveX SaveAs, critique 0 issues, exit 0,
every scratch document closed. It retries RPC_E_CALL_REJECTED (measured:
the first call after Documents.Add is refused) and tracks its documents by
the document list, since SaveAs renames them.
- Defects the evidence found, each fixed with a test that fails on the old
code:
* ezdxf dimension_diameter put the text beyond the SECOND chord point;
ActiveX AddDimDiametric puts it beyond the first (measured live: a d50
from (x,170) to (x,220), leader 10, text at (x,160)). Headlessly every
front-view diameter stood on its own chain dimension. ezdxf now follows
ActiveX.
* draw_part's anchor goes on MECH; ActiveX refuses entity.Layer on a
missing layer (measured -0x7ffdfff7 'Key not found'). draw.py ensures
every target layer before the first entity.
* bom.extract_records filtered on INSERT; ActiveX names it BLOCKREFERENCE
(ObjectName AcDbBlockReference) - the live parts list was empty.
* COM _entity_info reported no dimension text_position: ModelSpace.Item
narrows to IAcadEntity, which has no TextPosition (measured
AttributeError); read through _com_unnarrow (TextPosition measured on
AcDbDiametricDimension, WCS). dim_overlap compared bbox centres and a
diameter collided with its own bore.
* pid graph raised KeyError 'start' mid-critique on a LINE whose point read
AutoCAD refused while busy; such a line is left out.
* the validator read "ISO 4014 - M12x60" as fake dimension text.
- The published A/B report is re-run over the grown suite rather than
re-typed (26/39 -> 39/39, 13 fixed, 0 regressed), check_doc_numbers derives
the task count from the v5 matrix, the token table is remeasured with a
TOOL_PACKS=core,mech row (193 tools / 61,673 tokens), and the README's
collected-tests figure is retaken (3990).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd
107 lines
4.0 KiB
Python
107 lines
4.0 KiB
Python
"""Tests for dimension creation via ezdxf backend."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
async def test_dimension_linear(backend):
|
|
info = await backend.dimension_linear(0, 0, 100, 0, 50, 20, rotation=0)
|
|
assert info.handle
|
|
assert info.type == "DIMENSION"
|
|
|
|
|
|
async def test_dimension_aligned(backend):
|
|
info = await backend.dimension_aligned(0, 0, 100, 50, 50, 60)
|
|
assert info.handle
|
|
assert info.type == "DIMENSION"
|
|
|
|
|
|
async def test_dimension_angular(backend):
|
|
info = await backend.dimension_angular(0, 0, 100, 0, 0, 100, 50, 50)
|
|
assert info.handle
|
|
assert info.type == "DIMENSION"
|
|
|
|
|
|
async def test_dimension_radius(backend):
|
|
await backend.entity_create_circle(50, 50, 30)
|
|
info = await backend.dimension_radius(50, 50, 80, 50, leader_length=15)
|
|
assert info.handle
|
|
assert info.type == "DIMENSION"
|
|
|
|
|
|
async def test_dimension_diameter(backend):
|
|
info = await backend.dimension_diameter(20, 50, 80, 50, leader_length=10)
|
|
assert info.handle
|
|
assert info.type == "DIMENSION"
|
|
|
|
|
|
# ── the number on the dimension must be the number on the drawing ───────────
|
|
#
|
|
# `add_diameter_dim`/`add_radius_dim` take `mpoint` as a point ON the circle;
|
|
# `leader_length` is where the *text* sits. Passing `centre + (radius + leader)`
|
|
# as `mpoint` makes ezdxf measure to that point, so every diameter came out
|
|
# `2 x leader_length` too big and every radius `leader_length` too big -- at
|
|
# DEFAULT settings, silently, on a drawing whose whole purpose is the number.
|
|
# The live COM backend was never wrong here: AddDimDiametric takes the two
|
|
# chord points and the leader length as separate arguments.
|
|
|
|
|
|
async def test_a_diameter_dimension_measures_the_diameter(backend):
|
|
"""Two ends of a diameter of a true 40 mm circle."""
|
|
info = await backend.dimension_diameter(-20, 0, 20, 0)
|
|
|
|
dim = backend._doc.entitydb.get(info.handle)
|
|
assert dim.get_measurement() == pytest.approx(40.0)
|
|
|
|
|
|
async def test_the_text_stands_beyond_the_first_chord_point_as_activex_puts_it(backend):
|
|
"""AddDimDiametric(ChordPoint, FarChordPoint, LeaderLength), measured on
|
|
AutoCAD 2026: a 50 mm diameter from (x, 170) to (x, 220) with leader 10
|
|
had its text at (x, 160) - beyond the FIRST point. Both engines follow it."""
|
|
info = await backend.dimension_diameter(0, 25, 0, -25, leader_length=10.0)
|
|
dim = backend._doc.entitydb.get(info.handle)
|
|
text = dim.dxf.text_midpoint
|
|
assert text.y == pytest.approx(35.0)
|
|
assert text.x == pytest.approx(0.0)
|
|
|
|
|
|
async def test_the_leader_length_moves_the_text_not_the_measurement(backend):
|
|
"""The regression in one assertion: leader_length must not be measurable."""
|
|
near = await backend.dimension_diameter(-20, 0, 20, 0, leader_length=5.0)
|
|
far = await backend.dimension_diameter(-20, 0, 20, 0, leader_length=40.0)
|
|
|
|
measurements = [
|
|
backend._doc.entitydb.get(near.handle).get_measurement(),
|
|
backend._doc.entitydb.get(far.handle).get_measurement(),
|
|
]
|
|
assert measurements == pytest.approx([40.0, 40.0])
|
|
|
|
|
|
async def test_a_radius_dimension_measures_the_radius(backend):
|
|
info = await backend.dimension_radius(0, 0, 20, 0)
|
|
|
|
dim = backend._doc.entitydb.get(info.handle)
|
|
assert dim.get_measurement() == pytest.approx(20.0)
|
|
|
|
|
|
async def test_a_radius_measurement_ignores_the_leader_too(backend):
|
|
near = await backend.dimension_radius(0, 0, 20, 0, leader_length=5.0)
|
|
far = await backend.dimension_radius(0, 0, 20, 0, leader_length=40.0)
|
|
|
|
measurements = [
|
|
backend._doc.entitydb.get(near.handle).get_measurement(),
|
|
backend._doc.entitydb.get(far.handle).get_measurement(),
|
|
]
|
|
assert measurements == pytest.approx([20.0, 20.0])
|
|
|
|
|
|
async def test_an_off_axis_diameter_is_measured_from_its_own_chord(backend):
|
|
"""The two points are a diameter at any angle, not just horizontal."""
|
|
info = await backend.dimension_diameter(0, 0, 30, 40, leader_length=12.0)
|
|
|
|
dim = backend._doc.entitydb.get(info.handle)
|
|
assert dim.get_measurement() == pytest.approx(50.0)
|