Umut CANandClaude Opus 5
6024723d6b
The module docstring claimed "every value asserted here is a named row of a named table", but the converse did not hold: 27 of the 83 shipped rows had a dimension no test compared against a literal. ISO 4014/4017 M5 (s,k), ISO 4032 M5 (m), ISO 7089 M5 (d1,d2,h), ISO 4762 M4/M6/M10/M16 (dk,s,b) and D/B for 20 of the 33 ISO 15 bearings were constrained only by inequality tests (series growth) and by the bore-number rule - never by the transcribed number. For a task whose worst failure is "a standards table row that is not in the standard", those rows were exactly where such a row would hide. Measured before the fix with a pytest plugin that rewrote five rows in memory (M5 hex bolt s=k=99, M5 nut, M5 washer, M16 socket screw dk=s=b=99, 6307 as 78x20 instead of 80x21): 32 passed in 0.07s. All five now fail. Each of the five tables is pinned by an ISO*_ROWS dict literal carrying every dimension of every shipped size, parametrized one case per size/designation, plus a completeness test asserting the table's key set equals the literal's - so a row added later without a pin is red too (verified: a fabricated M14 head and 6011 bearing fail the completeness gate). 32 -> 93 tests, 0.06 -> 0.13 s. No production code changed; no ActiveX member is involved, so no live probe was required for this finding. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd
146 lines
4.9 KiB
Python
146 lines
4.9 KiB
Python
"""ISO 15 boundary dimensions and the ISO 8826 representation conventions.
|
|
|
|
``ISO15_ROWS`` below pins d, D and B for *every* one of the 33 shipped
|
|
designations, and a completeness test asserts its key set equals the module's.
|
|
Inequality tests (series growth, the bore-number rule) constrain a row; only a
|
|
literal pins it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from engineering.mech.standards import standards
|
|
from engineering.mech.standards.bearings import (
|
|
BALL_SYMBOL_FRACTION,
|
|
BEARING_SERIES,
|
|
CROSS_FRACTION,
|
|
DEEP_GROOVE,
|
|
SOURCE_ISO_15,
|
|
SOURCE_ISO_8826_1,
|
|
SOURCE_ISO_8826_2,
|
|
bearing,
|
|
list_bearings,
|
|
)
|
|
|
|
#: ISO 15:2017 Table 4 - every transcribed designation, (d, D, B) in mm.
|
|
ISO15_ROWS: dict[str, tuple[float, float, float]] = {
|
|
# dimension series 10 (600x)
|
|
"6000": (10.0, 26.0, 8.0),
|
|
"6001": (12.0, 28.0, 8.0),
|
|
"6002": (15.0, 32.0, 9.0),
|
|
"6003": (17.0, 35.0, 10.0),
|
|
"6004": (20.0, 42.0, 12.0),
|
|
"6005": (25.0, 47.0, 12.0),
|
|
"6006": (30.0, 55.0, 13.0),
|
|
"6007": (35.0, 62.0, 14.0),
|
|
"6008": (40.0, 68.0, 15.0),
|
|
"6009": (45.0, 75.0, 16.0),
|
|
"6010": (50.0, 80.0, 16.0),
|
|
# dimension series 02 (620x)
|
|
"6200": (10.0, 30.0, 9.0),
|
|
"6201": (12.0, 32.0, 10.0),
|
|
"6202": (15.0, 35.0, 11.0),
|
|
"6203": (17.0, 40.0, 12.0),
|
|
"6204": (20.0, 47.0, 14.0),
|
|
"6205": (25.0, 52.0, 15.0),
|
|
"6206": (30.0, 62.0, 16.0),
|
|
"6207": (35.0, 72.0, 17.0),
|
|
"6208": (40.0, 80.0, 18.0),
|
|
"6209": (45.0, 85.0, 19.0),
|
|
"6210": (50.0, 90.0, 20.0),
|
|
# dimension series 03 (630x)
|
|
"6300": (10.0, 35.0, 11.0),
|
|
"6301": (12.0, 37.0, 12.0),
|
|
"6302": (15.0, 42.0, 13.0),
|
|
"6303": (17.0, 47.0, 14.0),
|
|
"6304": (20.0, 52.0, 15.0),
|
|
"6305": (25.0, 62.0, 17.0),
|
|
"6306": (30.0, 72.0, 19.0),
|
|
"6307": (35.0, 80.0, 21.0),
|
|
"6308": (40.0, 90.0, 23.0),
|
|
"6309": (45.0, 100.0, 25.0),
|
|
"6310": (50.0, 110.0, 27.0),
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize(("designation", "expected"), sorted(ISO15_ROWS.items()))
|
|
def test_named_rows_match_iso15(designation, expected):
|
|
row = bearing(designation)
|
|
assert (row["d"], row["D"], row["B"]) == expected
|
|
assert row["designation"] == designation
|
|
assert row["source"] == SOURCE_ISO_15
|
|
|
|
|
|
def test_every_shipped_bearing_is_pinned_by_a_literal():
|
|
"""No shipped designation may escape the table above - that is where a wrong row hides."""
|
|
assert set(DEEP_GROOVE) == set(ISO15_ROWS)
|
|
|
|
|
|
def test_bore_number_rule_holds_across_every_series():
|
|
"""ISO 15: bore 00/01/02/03 = 10/12/15/17 mm; 04 and up = 5 x bore number."""
|
|
for series in ("60", "62", "63"):
|
|
assert bearing(f"{series}00")["d"] == 10.0
|
|
assert bearing(f"{series}01")["d"] == 12.0
|
|
assert bearing(f"{series}02")["d"] == 15.0
|
|
assert bearing(f"{series}03")["d"] == 17.0
|
|
for n in range(4, 11):
|
|
assert bearing(f"{series}{n:02d}")["d"] == 5.0 * n
|
|
|
|
|
|
def test_outside_diameter_and_width_grow_with_the_series():
|
|
for n in range(0, 11):
|
|
light = bearing(f"60{n:02d}")
|
|
medium = bearing(f"62{n:02d}")
|
|
heavy = bearing(f"63{n:02d}")
|
|
assert light["d"] == medium["d"] == heavy["d"]
|
|
assert light["D"] < medium["D"] < heavy["D"]
|
|
assert light["B"] < medium["B"] < heavy["B"]
|
|
|
|
|
|
def test_coverage_refusals_name_the_table():
|
|
with pytest.raises(ValueError, match="ISO 15"):
|
|
bearing("6011")
|
|
with pytest.raises(ValueError, match="ISO 15"):
|
|
bearing("6211")
|
|
with pytest.raises(ValueError, match="ISO 15"):
|
|
bearing("6311")
|
|
with pytest.raises(ValueError, match="ISO 15"):
|
|
bearing("61805") # the 618x light series is not transcribed
|
|
with pytest.raises(ValueError, match="ISO 15"):
|
|
bearing("6205-2RS") # a seal suffix is a variant this table does not carry
|
|
|
|
|
|
def test_representation_fractions_are_declared_conventions_not_table_values():
|
|
assert 0.0 < CROSS_FRACTION < 1.0
|
|
assert 0.0 < BALL_SYMBOL_FRACTION < 1.0
|
|
assert "ISO 8826-1" in SOURCE_ISO_8826_1
|
|
assert "ISO 8826-2" in SOURCE_ISO_8826_2
|
|
assert "ISO 15:2017" in SOURCE_ISO_15
|
|
|
|
|
|
def test_the_element_symbol_always_fits_inside_the_ring_rectangle():
|
|
"""The declared fractions must never draw a symbol outside the envelope."""
|
|
for name in DEEP_GROOVE:
|
|
row = bearing(name)
|
|
half_width = row["B"] / 2.0
|
|
half_gap = (row["D"] - row["d"]) / 4.0
|
|
assert BALL_SYMBOL_FRACTION * half_gap < half_width
|
|
assert CROSS_FRACTION * half_width < half_width
|
|
assert CROSS_FRACTION * half_gap < half_gap
|
|
|
|
|
|
def test_list_bearings_filters_by_series():
|
|
assert len(DEEP_GROOVE) == 33
|
|
assert len(list_bearings()) == 33
|
|
assert BEARING_SERIES == ("600x", "620x", "630x")
|
|
assert {row["designation"] for row in list_bearings("620x")} == {
|
|
f"62{n:02d}" for n in range(11)
|
|
}
|
|
with pytest.raises(ValueError, match="620x"):
|
|
list_bearings("622x")
|
|
|
|
|
|
def test_the_table_registers_itself():
|
|
assert "ISO 15" in standards()
|