2 Commits

Include renames

Author	SHA1	Message	Date
Umut CANandClaude Opus 5	f7528b2fa5	fix(com): every system variable is read and written on the ActiveX document, not the Application ... AcadApplication has no GetVariable/SetVariable members; they live on AcadDocument. Measured on the running AutoCAD 2026 (25.1s, 2026-09-22, scratch Documents.Add(), Close(False)): hasattr(app, 'GetVariable') -> False hasattr(app, 'SetVariable') -> False app.GetVariable('INSUNITS') -> AttributeError: ... IAcadApplication instance ... has no attribute 'GetVariable' doc.GetVariable('INSUNITS') -> 4 doc.GetVariable('MEASUREMENT') -> 1 doc.GetVariable('FILEDIA') -> 1; doc.SetVariable('FILEDIA', 0) -> None, reads back 0, restored to 1 doc.GetVariable('AUDITCTL') -> 0, 'CMDACTIVE' -> 0, 'USERS1' -> '' Fifteen call sites in backends/com_backend.py still went through the Application inside `try/except ... log.debug`, so on a live seat they silently degraded: MEASUREMENT defaulted every seat to metric, drawing_info reported units from a failed INSUNITS read, drawing_audit never set AUDITCTL, the CMDACTIVE guards of system_run_command / system_run_lisp never fired and run_lisp never read USERS1 back. All are rerouted through `_acad_doc()`; the try/except stays only where an optional read is defaulted (INSUNITS -> "Unknown", AUDITCTL absent on a host that lacks it, USERS1 after the expression ran) and the log line says so. Linetype loading, measured the same way: `SendCommand("_-LINETYPE _LOAD CENTER acadiso.lin\n\n")` loads nothing with FILEDIA=0 and leaves the command at `Enter an option [?/Create/Load/Set]:` (LASTPROMPT), which makes the whole seat answer RPC_E_CALL_REJECTED to every client until ESC is pressed; with FILEDIA=1 it opens the modal "Select Linetype File" dialog. `doc.Linetypes.Load("CENTER", "acadiso.lin")` returns None and the table grows 3 -> 4; a repeat raises 'Duplicate record name', an unknown name 'Undefined linetype', a missing file 'File system error'. `_ensure_linetype_loaded` and `linetype_load` now call `Linetypes.Load` (MEASUREMENT still read on the document to pick the .lin), touch no FILEDIA, and report a failure with the English excepinfo description. `apply_standard` reads every variable it will write before the first style is created, so a read the engine refuses is a refusal with nothing written (it used to fail after ISO-25 / ISOCP were created and current). Fakes: every application fake refuses GetVariable/SetVariable (tests/test_styles.py's COM fixture carried them on the Application, enshrining the wrong shape); the members exist on document fakes only. Regression tests per rerouted site: linetype load via Linetypes.Load with MEASUREMENT on the document, drawing_info units from the document, AUDITCTL set/restored on the document, CMDACTIVE/USERS1 on the document, apply_standard refusing before any write. Live end-to-end with the real ComBackend on a scratch document: apply_standard('iso') -> INSUNITS 4, ISO-25 (already in acadiso.dwt, created: false) and ISOCP (created: true) current, second call created: false / changed: {}; linetype_load('CENTER') -> Linetypes 3 -> 4, FILEDIA stays 1, repeat already_loaded, 'NOSUCHLT' refused by name; _ensure_linetype_loaded('HIDDEN') -> 3 -> 4; drawing_info units 'mm'; drawing_audit AUDITCTL 0 -> 0; system_run_command ok; system_run_lisp('(+ 40 2)') -> '42'. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-22 12:25:11 +03:00
Umut CANandClaude Opus 5	ca1c79fd01	fix: seven defects an adversarial audit found, and the gates that missed them ... Every one of these was reported ok/clean to the caller while being wrong. Silently wrong numbers - selection_filter(min_area) read `entity.dxf.get("area", 0.0)` for SOLID, TRACE and HATCH, none of which carry that attribute, so every hatch measured 0.0. A 1600 mm^2 hatch was excluded by min_area=1.0 while `filtered_by` asserted the filter had run, and COM (which reads ActiveX .Area) returned a different selection for the same call. It now answers from the measurement `entity_measure` uses, so the two cannot disagree. - Every headless dimension rendered through ezdxf's bare `Standard` style: 1.0 mm text with a comma decimal marker, against ISO 3098's 2.5 mm minimum and ISO 129's point -- while the document header itself said $DIMTXT 2.5. `ezdxf.new(setup=True)` is not the fix; measured, it renders a 100 mm dimension as "10000". The attributes are now stored explicitly. - Saving writes `dimrnd = 0.0` onto the Standard style, and ezdxf applies `xround(value, dimrnd)` whenever the attribute is present at all -- `xround(33.333, 0.0)` is 33. So on any reopened file, including one this server saved, every dimension was rounded to a whole unit before DIMDEC formatted it: a 12.75 mm feature dimensioned 13. AutoCAD means DIMRND 0 as *no* rounding; the sentinel is now discarded at every load site, and a real 0.5 mm rounding is left alone. - The DIM* header fold gave out-of-range values teeth they did not have when they died in the header: dim_decimals=-1 returned ok and then killed the next dimension with `ValueError: Format specifier missing precision` from inside ezdxf, and 40 printed forty digits of float noise onto the sheet. Ranges are now AutoCAD's own (DIMDEC 0-8, DIMZIN 0-15, lengths positive). Security - security.py recorded the policy as "sanitize_command and sanitize_lisp each have exactly ONE caller ... the policy is scoped to the CHANNEL". The premise was false. `_ensure_linetype_loaded` and `ComBackend.linetype_load` build `_-LINETYPE _LOAD {name} {file}` and hand it to SendCommand, which treats a newline and ';' as segment separators -- so a `linetype=` argument carrying either injected further AutoCAD commands, and the 36-verb denylist never saw that channel. Guarded with the DXF symbol-name rule (the injection characters fall out of it rather than being enumerated) plus validate_path for the file argument, which was also the one path-taking tool reaching the filesystem unchecked. The policy comment is corrected. Gates that could not see - drawing_critique returned zero issues on a quarantined document: all seven checks wrapped their backend call in a bare `except Exception`. CLAUDE.md rule 7 makes that call the gate an agent is told to trust. Only the quarantine now escapes; an ordinary broken check still degrades. `_check_dimension_legibility` also read `_doc` directly from the event loop thread, missing the gate and performing exactly the unsynchronised access the quarantine exists to prevent. `construction_clear` answered "deleted: 0" -- there was nothing to clear -- for the same reason. - The iso128 focus checked layer lineweights only, so a sheet lettered at 1.0 mm critiqued clean. It now reads the effective dimension height and separator, header-then-style, in the order the renderer resolves. - check_doc_numbers.py derived five values it never checked, and those were the ones that had drifted. The collected-test count (README said 1274, the tree had 1369) and the A/B pass-rate and Fixed columns are now gated. - benchmarks/README.md's v1.4.0 table was impossible on its face -- 21 passing plus 5 fixed is 26, not 24 -- and contradicted the report it linked, because `ab-v1.4.0-vs-v1.5.0.json` was regenerated from a tree that already carried the dimension fixes and so never measured the v1.5.0 tag. Replaced with a real run: ab-v1.4.0-vs-v1.5.1.json, 21/26 -> 26/26. Release gate - release.yml ran one ubuntu/3.11 lane, so a Windows-only defect could reach PyPI with no Windows job having executed. That is not hypothetical: v1.5.0 shipped `except pywintypes.com_error` raising NameError wherever pywin32 is absent. It now runs the same three lanes as ci.yml, Windows included. 1368 passed, 1 xfailed. ruff clean. Tool inventory and all 16 gated document numbers match the tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-06 23:07:50 +03:00