4 Commits

Include renames

Author	SHA1	Message	Date
Umut CANandClaude Opus 5	ca1c79fd01	fix: seven defects an adversarial audit found, and the gates that missed them ... Every one of these was reported ok/clean to the caller while being wrong. Silently wrong numbers - selection_filter(min_area) read `entity.dxf.get("area", 0.0)` for SOLID, TRACE and HATCH, none of which carry that attribute, so every hatch measured 0.0. A 1600 mm^2 hatch was excluded by min_area=1.0 while `filtered_by` asserted the filter had run, and COM (which reads ActiveX .Area) returned a different selection for the same call. It now answers from the measurement `entity_measure` uses, so the two cannot disagree. - Every headless dimension rendered through ezdxf's bare `Standard` style: 1.0 mm text with a comma decimal marker, against ISO 3098's 2.5 mm minimum and ISO 129's point -- while the document header itself said $DIMTXT 2.5. `ezdxf.new(setup=True)` is not the fix; measured, it renders a 100 mm dimension as "10000". The attributes are now stored explicitly. - Saving writes `dimrnd = 0.0` onto the Standard style, and ezdxf applies `xround(value, dimrnd)` whenever the attribute is present at all -- `xround(33.333, 0.0)` is 33. So on any reopened file, including one this server saved, every dimension was rounded to a whole unit before DIMDEC formatted it: a 12.75 mm feature dimensioned 13. AutoCAD means DIMRND 0 as *no* rounding; the sentinel is now discarded at every load site, and a real 0.5 mm rounding is left alone. - The DIM* header fold gave out-of-range values teeth they did not have when they died in the header: dim_decimals=-1 returned ok and then killed the next dimension with `ValueError: Format specifier missing precision` from inside ezdxf, and 40 printed forty digits of float noise onto the sheet. Ranges are now AutoCAD's own (DIMDEC 0-8, DIMZIN 0-15, lengths positive). Security - security.py recorded the policy as "sanitize_command and sanitize_lisp each have exactly ONE caller ... the policy is scoped to the CHANNEL". The premise was false. `_ensure_linetype_loaded` and `ComBackend.linetype_load` build `_-LINETYPE _LOAD {name} {file}` and hand it to SendCommand, which treats a newline and ';' as segment separators -- so a `linetype=` argument carrying either injected further AutoCAD commands, and the 36-verb denylist never saw that channel. Guarded with the DXF symbol-name rule (the injection characters fall out of it rather than being enumerated) plus validate_path for the file argument, which was also the one path-taking tool reaching the filesystem unchecked. The policy comment is corrected. Gates that could not see - drawing_critique returned zero issues on a quarantined document: all seven checks wrapped their backend call in a bare `except Exception`. CLAUDE.md rule 7 makes that call the gate an agent is told to trust. Only the quarantine now escapes; an ordinary broken check still degrades. `_check_dimension_legibility` also read `_doc` directly from the event loop thread, missing the gate and performing exactly the unsynchronised access the quarantine exists to prevent. `construction_clear` answered "deleted: 0" -- there was nothing to clear -- for the same reason. - The iso128 focus checked layer lineweights only, so a sheet lettered at 1.0 mm critiqued clean. It now reads the effective dimension height and separator, header-then-style, in the order the renderer resolves. - check_doc_numbers.py derived five values it never checked, and those were the ones that had drifted. The collected-test count (README said 1274, the tree had 1369) and the A/B pass-rate and Fixed columns are now gated. - benchmarks/README.md's v1.4.0 table was impossible on its face -- 21 passing plus 5 fixed is 26, not 24 -- and contradicted the report it linked, because `ab-v1.4.0-vs-v1.5.0.json` was regenerated from a tree that already carried the dimension fixes and so never measured the v1.5.0 tag. Replaced with a real run: ab-v1.4.0-vs-v1.5.1.json, 21/26 -> 26/26. Release gate - release.yml ran one ubuntu/3.11 lane, so a Windows-only defect could reach PyPI with no Windows job having executed. That is not hypothetical: v1.5.0 shipped `except pywintypes.com_error` raising NameError wherever pywin32 is absent. It now runs the same three lanes as ci.yml, Windows included. 1368 passed, 1 xfailed. ruff clean. Tool inventory and all 16 gated document numbers match the tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-06 23:07:50 +03:00
Umut CANandClaude Opus 5	25f8737132	release: v1.5.1 — bind guard failed open, [full] would not install, DIMSCALE did nothing ... Three defects found after 1.5.0 reached PyPI, two of them by the adversarial pass over the rewritten README. The HTTP bind guard failed open on the launch path it was written for. `_guarded_run_async` read the bind address from the `host` kwarg and treated an absent one as loopback. It is not: `fastmcp run` forwards that kwarg only when `--host` was passed, and fastmcp otherwise resolves the host from `fastmcp.settings.host`, which is environment-backed. So FASTMCP_HOST=0.0.0.0 fastmcp run server.py:mcp --transport http bound every interface -- 149 tools including file open/save and AutoCAD command execution, no token -- while the guard inspected the literal "127.0.0.1" and waved it through. v1.4.0's changelog claimed this guard "fires on every launch path"; it fired, and looked at the wrong host. It now resolves the effective host, and warns rather than staying silent if it cannot. `[com]` and `[full]` could not be installed off Windows. Both listed `pywin32>=306` with no environment marker, and pywin32 publishes Windows wheels and no sdist, so `pip install autocad-mcp-pro[full]` died at resolution on Linux and macOS -- and `[full]` is the extra the README recommended to contributors. CI never caught it because every Linux lane installs `[pdf]` or syncs from uv.lock, whose resolution markers hide the gap. Both entries carry `; sys_platform == "win32"` now, with a release-consistency test to keep them. `drawing_settings({"dimscale": ...})` reported success and changed nothing headlessly. It writes `$DIMSCALE`, which is what AutoCAD reads when it draws a dimension, so the call worked on COM; ezdxf renders from the dimstyle table entry and never consults the header. One call, one reported success, two different drawings. The header value now folds into the per-dimension override on all five dimension tools -- including `dimension_aligned` and `dimension_angular`, which do not share the tolerance-override path and the obvious fix would have missed. DIMSCALE 1.0 writes nothing. README: every engine-conditional family in the feature table now says which engine (boundary tracing, WIPEOUT/REVCLOUD/MTEXT masks, CHSPACE, typed hatch edge paths, headless undo), and the checkout install line stopped recommending an extra that could not resolve on the reader's platform. 1257 passed, 1 xfailed. 1.5.0 is to be yanked: its diameter and radius callouts put wrong numbers on drawings at default settings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-06 14:28:35 +03:00
Umutcan EdizsalanandCursor	9ec6c4a989	style: apply ruff format across the repository ... ruff format was never run repo-wide; CI now enforces 'ruff format --check', so normalize every module once. No behavior changes. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-07-23 15:14:51 +03:00
Umutcan Edizsalan	712cf00c5c	v1.2.0 ... Adds production-grade engineering features and tools: 2D GD&T (feature control frames + datum features) via engineering/gdt.py, ISO‑129 dimension tolerance support (engineering/tolerances.py) and an ezdxf/COM plumbing for toleranced dims, a scalar drawing score + invalidity ratio (engineering/scoring.py) wired into drawing_finalize, in-place entity editors (entity_edit_text/entity_edit_geometry), and a friendly drawing_settings facade. Includes server tool wiring, COM/ezdxf backend implementations, datum-consistency critique, many unit tests, README/CLAUDE/CHANGELOG updates, and a version bump to 1.2.0. Also corrects COM backend capability label (entities_2d).	2026-07-07 11:03:08 +03:00