Umut CANandClaude Opus 5
25f8737132
Three defects found after 1.5.0 reached PyPI, two of them by the adversarial
pass over the rewritten README.
The HTTP bind guard failed open on the launch path it was written for.
`_guarded_run_async` read the bind address from the `host` kwarg and treated an
absent one as loopback. It is not: `fastmcp run` forwards that kwarg only when
`--host` was passed, and fastmcp otherwise resolves the host from
`fastmcp.settings.host`, which is environment-backed. So
FASTMCP_HOST=0.0.0.0 fastmcp run server.py:mcp --transport http
bound every interface -- 149 tools including file open/save and AutoCAD command
execution, no token -- while the guard inspected the literal "127.0.0.1" and
waved it through. v1.4.0's changelog claimed this guard "fires on every launch
path"; it fired, and looked at the wrong host. It now resolves the effective
host, and warns rather than staying silent if it cannot.
`[com]` and `[full]` could not be installed off Windows. Both listed
`pywin32>=306` with no environment marker, and pywin32 publishes Windows wheels
and no sdist, so `pip install autocad-mcp-pro[full]` died at resolution on
Linux and macOS -- and `[full]` is the extra the README recommended to
contributors. CI never caught it because every Linux lane installs `[pdf]` or
syncs from uv.lock, whose resolution markers hide the gap. Both entries carry
`; sys_platform == "win32"` now, with a release-consistency test to keep them.
`drawing_settings({"dimscale": ...})` reported success and changed nothing
headlessly. It writes `$DIMSCALE`, which is what AutoCAD reads when it draws a
dimension, so the call worked on COM; ezdxf renders from the dimstyle table
entry and never consults the header. One call, one reported success, two
different drawings. The header value now folds into the per-dimension override
on all five dimension tools -- including `dimension_aligned` and
`dimension_angular`, which do not share the tolerance-override path and the
obvious fix would have missed. DIMSCALE 1.0 writes nothing.
README: every engine-conditional family in the feature table now says which
engine (boundary tracing, WIPEOUT/REVCLOUD/MTEXT masks, CHSPACE, typed hatch
edge paths, headless undo), and the checkout install line stopped recommending
an extra that could not resolve on the reader's platform.
1257 passed, 1 xfailed. 1.5.0 is to be yanked: its diameter and radius callouts
put wrong numbers on drawings at default settings.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
140 lines
5.1 KiB
Python
140 lines
5.1 KiB
Python
"""Tests for the drawing_settings facade — friendly read/change of AutoCAD
|
|
system variables (units, precision, scales, osnap, …)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
async def test_read_snapshot_returns_known_keys(backend):
|
|
snap = await backend.drawing_settings()
|
|
assert snap["ok"] is True
|
|
s = snap["settings"]
|
|
for key in ("units", "linear_precision", "ltscale", "dimscale", "osmode"):
|
|
assert key in s
|
|
|
|
|
|
async def test_set_and_read_back_units_by_name(backend):
|
|
res = await backend.drawing_settings({"units": "mm"})
|
|
assert res["ok"] is True
|
|
assert res["applied"]["units"] == "mm"
|
|
snap = await backend.drawing_settings()
|
|
assert snap["settings"]["units"]["name"] == "mm"
|
|
assert snap["settings"]["units"]["code"] == 4
|
|
|
|
|
|
async def test_set_units_cm_and_inch_codes(backend):
|
|
await backend.drawing_settings({"units": "cm"})
|
|
assert (await backend.drawing_settings())["settings"]["units"]["code"] == 5
|
|
await backend.drawing_settings({"units": "inch"})
|
|
assert (await backend.drawing_settings())["settings"]["units"]["code"] == 1
|
|
|
|
|
|
async def test_set_numeric_settings(backend):
|
|
res = await backend.drawing_settings(
|
|
{
|
|
"dimscale": 2.0,
|
|
"linear_precision": 3,
|
|
"ltscale": 0.5,
|
|
}
|
|
)
|
|
assert res["ok"] is True
|
|
snap = (await backend.drawing_settings())["settings"]
|
|
assert snap["dimscale"] == 2.0
|
|
assert snap["linear_precision"] == 3
|
|
assert snap["ltscale"] == 0.5
|
|
|
|
|
|
async def test_unknown_key_reports_error_without_failing_others(backend):
|
|
res = await backend.drawing_settings({"dimscale": 1.5, "bogus_key": 1})
|
|
assert res["applied"]["dimscale"] == 1.5
|
|
assert "bogus_key" in res["errors"]
|
|
assert res["ok"] is False
|
|
|
|
|
|
async def test_bad_unit_value_is_reported(backend):
|
|
res = await backend.drawing_settings({"units": "furlongs"})
|
|
assert "units" in res["errors"]
|
|
|
|
|
|
# ── server tool wiring ──────────────────────────────────────────────────────
|
|
|
|
|
|
class _FakeCtx:
|
|
def __init__(self, backend):
|
|
self.lifespan_context = {"backend": backend}
|
|
|
|
async def info(self, *a, **k):
|
|
pass
|
|
|
|
|
|
async def test_server_tool_reads_and_writes(backend):
|
|
import server
|
|
|
|
ctx = _FakeCtx(backend)
|
|
write = await server.drawing_settings(settings={"units": "mm", "dimscale": 1.0}, ctx=ctx)
|
|
assert write["ok"] is True
|
|
read = await server.drawing_settings(ctx=ctx)
|
|
assert read["settings"]["units"]["name"] == "mm"
|
|
|
|
|
|
# ── DIMSCALE has to reach the dimension, not just the header ────────────────
|
|
|
|
|
|
def _dim_text_heights(backend, handle) -> list[float]:
|
|
"""The text heights actually rendered into the dimension's geometry block.
|
|
|
|
The override lands in the dimension's XDATA, not on `dim.dxf`, so the only
|
|
honest check is the drawing it produces.
|
|
"""
|
|
dim = backend._doc.entitydb.get(handle)
|
|
block = backend._doc.blocks.get(dim.dxf.geometry)
|
|
heights = []
|
|
for entity in block:
|
|
if entity.dxftype() == "MTEXT":
|
|
heights.append(round(float(entity.dxf.char_height), 3))
|
|
elif entity.dxftype() == "TEXT":
|
|
heights.append(round(float(entity.dxf.height), 3))
|
|
return sorted(set(heights))
|
|
|
|
|
|
async def test_dimscale_changes_the_dimension_it_is_set_before(backend):
|
|
"""`drawing_settings({"dimscale": ...})` reported success and did nothing.
|
|
|
|
It writes the `$DIMSCALE` header variable, which is what AutoCAD reads when
|
|
it creates a dimension — so on the live backend the call worked. ezdxf
|
|
renders dimensions from the dimstyle table entry and never consults the
|
|
header, so headlessly the text stayed the same size however large the
|
|
number was: one call, one reported success, two different drawings.
|
|
"""
|
|
plain = await backend.dimension_linear(0, 0, 100, 0, 50, -30)
|
|
await backend.drawing_settings({"dimscale": 4.0})
|
|
scaled = await backend.dimension_linear(0, 0, 100, 0, 50, -60)
|
|
|
|
before = _dim_text_heights(backend, plain.handle)
|
|
after = _dim_text_heights(backend, scaled.handle)
|
|
assert before and after
|
|
assert after == pytest.approx([h * 4.0 for h in before]), (
|
|
f"DIMSCALE=4 must scale the dimension text: {before} -> {after}"
|
|
)
|
|
|
|
|
|
async def test_the_default_dimscale_adds_no_override(backend):
|
|
"""DIMSCALE 1.0 is the default; it must not litter every dimension."""
|
|
plain = await backend.dimension_linear(0, 0, 100, 0, 50, -30)
|
|
|
|
dim = backend._doc.entitydb.get(plain.handle)
|
|
assert not dim.dxf.hasattr("dimscale") or dim.dxf.dimscale == pytest.approx(1.0)
|
|
|
|
|
|
async def test_dimscale_reaches_aligned_and_angular_too(backend):
|
|
"""Those two do not go through `build_dim_override`, so they were missed."""
|
|
await backend.drawing_settings({"dimscale": 3.0})
|
|
aligned = await backend.dimension_aligned(0, 0, 60, 60, 40, 70)
|
|
angular = await backend.dimension_angular(0, 0, 50, 0, 0, 50, 30, 30)
|
|
|
|
for handle in (aligned.handle, angular.handle):
|
|
assert _dim_text_heights(backend, handle) == pytest.approx([3.0])
|