`add_diameter_dim` / `add_radius_dim` measure to the point they are handed; `leader_length` is a text placement. The ezdxf backend passed `centre + (radius + leader)` as that point, so the leader became part of the measurement: a true 40 mm bore was dimensioned 60 at the default `leader_length=10`, and 108 at 34. Radius callouts were `leader_length` too large the same way. This is the worst class of defect for this project -- a wrong number, at default settings, on the one part of a drawing that exists to carry numbers -- and it shipped in v1.4.0 and earlier. The size now comes from `radius` and `location` only places the text. The live COM backend was never affected: ActiveX's AddDimDiametric takes the two chord points and the leader length as separate arguments. The two engines had been disagreeing by 2 x leader_length on the same call. Found while building the drawing for the new README, whose own bore callout was wrong. Two checks added to correctness_suite.py; both report fail -> pass against v1.4.0, not miss -> pass, which is what separates a repaired defect from new capability in that lane. A/B is now 21/26 -> 26/26, five fixed, zero regressed. README rewritten from scratch - Hero is a real ISO A3 sheet the server drew: m6 z24 involute spur gear, DIN 6885 keyed bore, section A-A, ISO 129 dimensions, ISO 286 H7 fit, ISO 7200 title block, 56 entities, drawing_critique clean. New scripts/render_readme_showcase.py rebuilds it, and the tool-call sequence that produces it is printed in the page. - Star history chart, badge row, capability matrix, five evidence lanes, and a "what this release is bad at" section carrying the 28% throughput regression. - Every image and repo link is now an absolute URL: README.md is the PyPI long description, where relative paths 404. Corrections this work forced, all measured - The df=0 example was wrong. FILLET is already in entity_fillet's own text; the commands that genuinely scored zero are WBLOCK, PEDIT, OVERKILL, LAYTRANS and MATCHPROP. - 40,305 tokens is the tools/list wire payload; ~25,143 is the part forwarded to the model. The old wording said "of schema", which is neither. - `--tokenizer anthropic` needs a package and credentials this repo does not lock, and refuses rather than falling back. Said so. - Discovery ranks over the 149-tool advertised catalog, not the 154 registered. - Five middlewares, not four; the fifth is what makes refusals machine-readable. - Five of the 27 capability keys are environment-dependent, so the matrix carries footnotes instead of bare ticks. - "Every coordinate is WCS" has one deliberate exception: TEXT rotation. - render_live_chart's axis still said "fixed 10-task matrix" while our bar came from v3's fifteen. Each bar now carries its own matrix. - .env.example said MAX_UNDO_STACK=50 (code: 5) and omitted four real variables, two of them the remote-HTTP controls. - server.json described an empty ALLOWED_PATHS as blocking access. It disables the allowlist. - server.py called the lean profile ~46 tools; it is 47. - backends/capability.py cited a test file that does not exist. 1249 passed, 1 xfailed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
135 lines
5.9 KiB
Python
135 lines
5.9 KiB
Python
"""Optional contract methods: declared once, refused loudly, gated by a test.
|
|
|
|
The backend contract is large (112 abstract methods before this file existed,
|
|
and the plan adds ~39 more). Every one of them is an `@abstractmethod`, which
|
|
means adding a single method to the contract makes **both** backends fail at
|
|
instantiation until both are written — and two test modules construct
|
|
`ComBackend` at import time, so the whole suite goes red on a half-finished
|
|
edit. That is a real cost paid on every contract change.
|
|
|
|
The obvious fix is to give new methods a default body. The obvious default is
|
|
wrong: returning ``{"ok": False, "capability": ...}`` from a method nobody
|
|
implemented produces exactly the quiet "this didn't work and nothing told you"
|
|
that the v1.5.0 honesty pass spent a milestone deleting. A default that lies
|
|
quietly is worse than a build break.
|
|
|
|
So `@capability` gives a default that **raises**
|
|
`UnsupportedCapabilityError` — the same typed refusal the deliberate
|
|
boundaries raise, carrying the same `capability` key, surfaced by the same
|
|
`CapabilityRefusalMiddleware`, and indistinguishable to a client from a
|
|
hand-written refusal. Three properties follow:
|
|
|
|
* An unimplemented method refuses instead of pretending. It cannot silently
|
|
succeed and it cannot silently do nothing.
|
|
* The refusal is *declared*: `test_capability_contract.py` fails if a key used here is
|
|
missing from either backend's `CapabilityMap`, so `system_capabilities` can
|
|
never disagree with what a call actually does. This is the part that keeps
|
|
the escape hatch honest — without it, `@capability` would just be a way to
|
|
ship undeclared holes.
|
|
* Overriding is ordinary subclassing. A backend that implements the method
|
|
simply defines it; nothing needs to be un-registered.
|
|
|
|
`@abstractmethod` remains the default for anything both backends must have.
|
|
Reach for `@capability` only when a method is genuinely optional — an engine
|
|
boundary (no ACIS kernel headlessly) rather than an unfinished chore.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import functools
|
|
from collections.abc import Callable
|
|
from typing import Any
|
|
|
|
__all__ = [
|
|
"UnsupportedCapabilityError",
|
|
"capability",
|
|
"capability_keys",
|
|
"is_capability_default",
|
|
]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# The refusal vocabulary
|
|
#
|
|
# This lives here rather than in ``backends.base`` because the contracts import
|
|
# the decorator and ``base`` imports the contracts — putting the exception in
|
|
# ``base`` makes that a cycle. ``backends.base`` re-exports both names, so
|
|
# ``from backends.base import UnsupportedCapabilityError`` is unchanged for the
|
|
# rest of the repo.
|
|
#
|
|
# There is exactly one authoring rule: a backend that cannot do a thing RAISES
|
|
# ``UnsupportedCapabilityError(capability, message)``, where ``capability`` is a
|
|
# key of ``capabilities().features`` so a client can pre-check the same boundary
|
|
# through ``system_capabilities`` instead of parsing English. Tools never catch
|
|
# it and never hand-build refusal payloads — one middleware turns it into the
|
|
# wire payload, and ``cad_batch`` turns it into a step row. One class object,
|
|
# defined once: two look-alike types would silently break every ``isinstance``
|
|
# classifier.
|
|
#
|
|
# The ``{"ok": False, "error": ...}`` returned-dict shape stays legal only for
|
|
# soft failures that are not capability boundaries ("Layout not found", "No
|
|
# active transaction").
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _unsupported(error: str, capability_key: str) -> dict:
|
|
"""Build a backend's machine-readable "this backend can't" payload."""
|
|
return {"ok": False, "error": error, "capability": capability_key}
|
|
|
|
|
|
class UnsupportedCapabilityError(RuntimeError):
|
|
"""Raised when a call needs a capability this backend does not have.
|
|
|
|
Stays a plain ``RuntimeError``: rebasing it on ``FastMCPError`` was measured
|
|
and changes nothing a client can observe, because the refusal is carried by
|
|
``ToolResult(structured_content=..., is_error=True)`` rather than by the
|
|
exception class. ``to_dict()`` keeps the ``{ok, error, capability}`` payload
|
|
attached to the raise so the boundary survives the ``__cause__`` chain.
|
|
"""
|
|
|
|
def __init__(self, capability: str, error: str):
|
|
super().__init__(error)
|
|
self.capability = capability
|
|
|
|
def to_dict(self) -> dict:
|
|
return _unsupported(str(self), self.capability)
|
|
|
|
|
|
#: ``{capability_key: (method_name, ...)}`` for every method declared optional.
|
|
#: Populated at import by the decorator and read by the parity gate.
|
|
_REGISTRY: dict[str, set[str]] = {}
|
|
|
|
|
|
def capability(key: str, *, reason: str = "") -> Callable[[Callable], Callable]:
|
|
"""Mark a contract method optional, defaulting to a typed refusal.
|
|
|
|
Args:
|
|
key: capability name; must appear in **both** backends' capability maps.
|
|
reason: appended to the refusal message. Say what the caller can do
|
|
instead, not merely that they cannot do this.
|
|
"""
|
|
|
|
def decorate(func: Callable) -> Callable:
|
|
@functools.wraps(func)
|
|
async def default(self, *args: Any, **kwargs: Any):
|
|
message = f"{func.__name__}: not supported by the {self.name} backend"
|
|
raise UnsupportedCapabilityError(key, f"{message}. {reason}".rstrip())
|
|
|
|
default.__capability__ = key
|
|
default.__is_capability_default__ = True
|
|
_REGISTRY.setdefault(key, set()).add(func.__name__)
|
|
return default
|
|
|
|
return decorate
|
|
|
|
|
|
def capability_keys() -> dict[str, set[str]]:
|
|
"""Every optional-capability key and the methods declared under it."""
|
|
return {key: set(names) for key, names in _REGISTRY.items()}
|
|
|
|
|
|
def is_capability_default(owner: type, method_name: str) -> bool:
|
|
"""True when ``owner`` inherited the refusing default rather than implementing it."""
|
|
attribute = getattr(owner, method_name, None)
|
|
return bool(getattr(attribute, "__is_capability_default__", False))
|