Umut CANandClaude Opus 5.5
67d578e09a
engineering/arch/faces.py finds the closed faces a set of straight segments bounds: endpoints within tol merge, every segment splits where another crosses or touches it (the T-junction a partition makes), dangling edges are pruned, and the half-edge walk turns to the next edge clockwise so every bounded face comes out counter-clockwise. A piece nested inside a face of another piece is a hole in it, so a ring of walls measures its body and a room with a column measures its floor. Areas come from engineering.measure.polygon_area_perimeter, the arithmetic analysis_measure_entity reports. engineering/arch/rooms.py labels a room with the area of the face its point lies in - a 4000 x 5000 room between 200 mm walls reads 20.00 m2, never the axis area - and writes the room record onto the name text. Opening records close door and window gaps along the wall faces, so two rooms either side of a door stay two rooms. rooms_detect reads any plan's lines, drops faces under min_area and thin wall bodies (mean width under 600 mm, a declared heuristic), reports confidence 1.0 for faces enclosed only by our wall layer and 0.6 otherwise, lists arcs as skipped rather than flattening them, and never modifies the drawing. Two hardenings beyond the plan text, each with a test: read_records pages the current space once and filters to the arch layers locally (the plan paged it once per arch layer - twelve full scans, each a cross-process call per entity on a live seat), keeping the same layer-then-drawing order; and an opening record whose offset falls outside its wall (a stale record) is listed in omitted instead of raising out of the read-only detector. No new ActiveX member is called: both tools compose entity_list, entity_get/set_xdata, layer_list and draw_prims, whose COM paths are already live-verified. SECTION 25 opens on this branch with arch_room and arch_rooms_detect under the rooms marker; until Task 9 gives arch its group they file under entity_creation and entity_query. Alias records, a regenerated inventory, the README snapshot at 231 tools in 25 groups and the frozen group-size snapshot follow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd
78 lines
2.9 KiB
Python
78 lines
2.9 KiB
Python
"""arch_room and arch_rooms_detect over the MCP wire, on a fresh headless document."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
import pytest_asyncio
|
|
from fastmcp import Client
|
|
|
|
import server
|
|
from engineering.arch.layers import ARCH_ROLE_LAYER
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
WALL = ARCH_ROLE_LAYER["wall"]
|
|
|
|
|
|
def rect(x0, y0, x1, y1):
|
|
return [((x0, y0), (x1, y0)), ((x1, y0), (x1, y1)), ((x1, y1), (x0, y1)), ((x0, y1), (x0, y0))]
|
|
|
|
|
|
@pytest_asyncio.fixture
|
|
async def client(monkeypatch):
|
|
"""In-memory client on a fresh headless document - never the operator's AutoCAD."""
|
|
monkeypatch.setenv("AUTOCAD_MCP_BACKEND", "ezdxf")
|
|
async with Client(server.mcp) as connected:
|
|
status = (await connected.call_tool("system_status", {})).structured_content or {}
|
|
assert status.get("backend") == "ezdxf", "these tests must never touch live AutoCAD"
|
|
await connected.call_tool("drawing_new", {})
|
|
yield connected
|
|
|
|
|
|
async def draw_room(client, layer):
|
|
"""A 4000 x 5000 room between 200 mm walls: outer and inner outline."""
|
|
for (x1, y1), (x2, y2) in [
|
|
*rect(-200.0, -200.0, 4200.0, 5200.0),
|
|
*rect(0.0, 0.0, 4000.0, 5000.0),
|
|
]:
|
|
await client.call_tool(
|
|
"entity_create_line", {"x1": x1, "y1": y1, "x2": x2, "y2": y2, "layer": layer}
|
|
)
|
|
|
|
|
|
async def test_arch_room_labels_the_measured_area(client):
|
|
await draw_room(client, WALL)
|
|
result = await client.call_tool(
|
|
"arch_room", {"name": "LIVING", "number": "01", "x": 2000.0, "y": 2500.0}
|
|
)
|
|
room = result.structured_content["room"]
|
|
assert room["area"] == pytest.approx(20_000_000.0)
|
|
assert room["area_text"] == "20.00 m²"
|
|
assert result.structured_content["layer"] == ARCH_ROLE_LAYER["room"]
|
|
|
|
|
|
async def test_arch_rooms_detect_reads_the_room_back_without_drawing(client):
|
|
await draw_room(client, "DUVAR")
|
|
before = (await client.call_tool("analysis_entity_stats", {})).structured_content
|
|
result = (await client.call_tool("arch_rooms_detect", {})).structured_content
|
|
assert result["layers"] == ["DUVAR"]
|
|
assert [r["area"] for r in result["rooms"]] == [pytest.approx(20_000_000.0)]
|
|
assert result["confidence_min"] == 0.6
|
|
after = (await client.call_tool("analysis_entity_stats", {})).structured_content
|
|
assert after["total_entities"] == before["total_entities"]
|
|
|
|
|
|
async def test_a_point_outside_every_room_is_refused_over_the_wire(client):
|
|
await draw_room(client, WALL)
|
|
result = await client.call_tool(
|
|
"arch_room", {"name": "X", "x": 9000.0, "y": 9000.0}, raise_on_error=False
|
|
)
|
|
assert result.is_error is True
|
|
assert "room.at: (9000, 9000) lies in no closed face" in result.content[0].text
|
|
|
|
|
|
async def test_the_detector_is_advertised_read_only(client):
|
|
tools = {tool.name: tool for tool in await client.list_tools()}
|
|
assert tools["arch_rooms_detect"].annotations.readOnlyHint is True
|
|
assert tools["arch_room"].annotations.destructiveHint is False
|