autocad-mcp-pro

225 Commits 2 Branches 5 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
Umut CANandClaude Opus 5.5	898e775f93	bench: matrix v5 adds mech_assembly; the correctness suite grows with the mechanical and sheet checks The evidence for tracks B and G, in the shape tracks A and E used. - benchmarks/tasks_v5.py: 18 tasks, DEFAULT_MATRIX = "v5"; v4, v3 and v2 stay addressable so an earlier report reproduces exactly rather than being only described. mech_assembly is roadmap criterion 3 - a flange-coupling sheet built from the part model and the sheet standard, through the code the tools call (apply_titleblock, draw_part/add_view/dimension_part, insert_std_part, extract_records -> draw_bom_table, add_balloon), gated on two numbers that cannot be negotiated: drawing_critique(focus=None) returns zero issues and the finalize score is at least 90 (it scores 100, 18/18 on the v5 matrix). The adapter returns the focuses that fired, so a regression names itself, and a test drops one balloon to prove the gate fails and names mech_bom_balloon_mismatch. - Seven correctness checks (32 -> 39). mech_section_hatch_area is the one that cannot be faked: a sleeve of length 60, outside diameter 40 and bore 20 cuts two faces totalling 1200 mm^2 exactly, read back out of the drawing through entity_measure. sheet_frame_iso5457_a3 pins the A3 frame (20,10 to 410,287 inside the 420 x 297 trimmed sheet); mech_iso286_on_dimension pins 40 H7 at +0.025/0 through the layout; std_part_iso4014_m12 pins s = 18 and k = 7.5 by value; mech_thread_unrepresented_is_caught is the seventh: a quality gate that never fires is not a gate. - scripts/smoke_mech_com.py executed every new COM path once on AutoCAD 2026 (25.1s): frame, title block, a sectioned shaft with 12 dimensions, an ISO 4014 block with 1 ACADMCP_MECH chunk, a weld symbol, the parts list read off the drawing, a linked balloon, an xref attached / listed / detached, a 31687-byte .dwg (AC1032) through ActiveX SaveAs, critique 0 issues, exit 0, every scratch document closed. It retries RPC_E_CALL_REJECTED (measured: the first call after Documents.Add is refused) and tracks its documents by the document list, since SaveAs renames them. - Defects the evidence found, each fixed with a test that fails on the old code: * ezdxf dimension_diameter put the text beyond the SECOND chord point; ActiveX AddDimDiametric puts it beyond the first (measured live: a d50 from (x,170) to (x,220), leader 10, text at (x,160)). Headlessly every front-view diameter stood on its own chain dimension. ezdxf now follows ActiveX. * draw_part's anchor goes on MECH; ActiveX refuses entity.Layer on a missing layer (measured -0x7ffdfff7 'Key not found'). draw.py ensures every target layer before the first entity. * bom.extract_records filtered on INSERT; ActiveX names it BLOCKREFERENCE (ObjectName AcDbBlockReference) - the live parts list was empty. * COM _entity_info reported no dimension text_position: ModelSpace.Item narrows to IAcadEntity, which has no TextPosition (measured AttributeError); read through _com_unnarrow (TextPosition measured on AcDbDiametricDimension, WCS). dim_overlap compared bbox centres and a diameter collided with its own bore. * pid graph raised KeyError 'start' mid-critique on a LINE whose point read AutoCAD refused while busy; such a line is left out. * the validator read "ISO 4014 - M12x60" as fake dimension text. - The published A/B report is re-run over the grown suite rather than re-typed (26/39 -> 39/39, 13 fixed, 0 regressed), check_doc_numbers derives the task count from the v5 matrix, the token table is remeasured with a TOOL_PACKS=core,mech row (193 tools / 61,673 tokens), and the README's collected-tests figure is retaken (3990). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-23 13:30:02 +03:00
Umut CANandClaude Opus 5.5	5388440c27	fix(task-7): rotation honoured end to end, each view dimensioned once, refusals that name their path - rotation turns the whole sheet of views about `at` as one rigid body: the prims, the recorded WCS `bbox` (plus the sheet-frame `frame_bbox` the next view is laid out against), the detail marker, and every dimension intent (points, text position, and the linear measuring direction + rotation). Measured headless: rotation=90 at (100,100) now draws (70,100)-(100,172), records exactly that box, and leaves only the 2 diameter chord defpoints off-geometry (was 4, up to 47.5 mm away). - dimension_part dimensions only views whose record is not `dimensioned`, takes `views=[indices]`, refuses a view already dimensioned by name (ISO 129-1), writes the flag back, places the hole table once, and refuses a fit no target view claims before drawing anything. A view the dimension layer emits nothing for (a detail) is reported in `skipped` and left unflagged. mech_dimension_part gains the `views` argument. - draw_prims checks hatch_add_boundary's {"ok": False}: the hatch is removed and the failure raised, never left solid through the bore. An engine whose capability map says `hatch_edge_paths` is unsupported (the live one) is refused before any prim of the view is drawn. - a view scale other than 1.0 is refused by name in draw_part and add_view (views are drawn full size; the scale would only have been recorded). - add_view's collision step compares real rectangles on both axes and steps along the projection axis layout_origin chose, so a third-angle view is never shoved back onto the front view and a top view keeps its alignment. - draw_from_spec validates `at` / `rotation` into the `parts[i]:` path and a transaction that cannot open is a ValueError (a ToolError at the tool). No new ActiveX member is called: the change composes existing contract members (dimension_linear rotation, entity_delete, capabilities()). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-23 12:20:25 +03:00
Umut CANandClaude Opus 5	8b14d4ef8d	feat(task-7): SECTION 21 - the mechanical part model as six tools engineering/mech/draw.py is the only module in the package that touches a backend: it turns the pure engine's primitive descriptions into entity_create_* and dimension_* calls, places them in WCS, and writes the part model back onto the drawing as ACADMCP_MECH XDATA on an anchor POINT. It is not a contract member and neither are the tools - exactly like gear_draw_* and titleblock_apply_iso_a3, it composes the generic members, so it is written once and works on both engines by construction and no capability key is needed. No new ActiveX call was written, so there was nothing to probe on the live seat; measured instead that every one of the 23 backend members draw.py calls exists on ComBackend and that ComBackend has no abstract methods left. mech_part_draw takes one model - a turned profile or a plate outline plus typed features - and draws its views in first-angle positions (third on request), dimensions them and records the placement. mech_view_add reads the model back out of the drawing and adds a side, top, section (full/half/offset/revolved) or detail view months later without the caller re-describing the part. mech_dimension_part lays out ISO 129 dimensions with no overlapping text, resolves ISO 286 fits against the measured nominal, and moves the holes into a table past a threshold. mech_hole_pattern exposes the same expansion for a drawing that was never built from the model - with its own diameter guard, because Hole.validate needs a part and a standalone pattern has none. mech_part_inspect reads the payload back and never modifies the drawing. mech_part_from_spec draws a whole sheet inside one transaction. Every part is validated before the transaction opens, so a refusal leaves the drawing untouched and names the path (parts[1]: segments[0].d_outer: ...), and the rollback is shielded with the shape engineering/pid/spec.py documents: anyio cancellation is level-triggered, so a bare await in the handler would be cancelled before the rollback body ran and leave half a sheet inside an open transaction. fits goes through dimension_intents(fits=...), the API Task 6 shipped, rather than being stamped on at draw time: that is the path that validates a key by name and refuses a fit on a reference dimension or on a hole that moved into the table. It is scoped per view first - a fit on segment[0] names nothing in the end view, and refusing there would make a correct three-view sheet undrawable - and any key no view claimed is handed back to dimension_intents so the refusal is written in its own vocabulary. SECTION 21 registers the six tools in the new mech pack, with alias records (SECTIONPLANE, ARRAY plus shop-floor synonyms in English and Turkish - mil, kademeli mil, kama, pah, kesit, gorunus), a regenerated tool inventory, the README release snapshot at 210 tools in 24 groups, and the frozen group-size snapshot gaining mech: 6. Lean is deliberately untouched here: spec section 11 puts three of these on the lean surface together with group G's two sheet tools, and Task 15 makes that edit once across all four branches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-22 23:17:29 +03:00

Author

SHA1

Message

Date

Umut CANandClaude Opus 5.5

898e775f93

bench: matrix v5 adds mech_assembly; the correctness suite grows with the mechanical and sheet checks

The evidence for tracks B and G, in the shape tracks A and E used.

- benchmarks/tasks_v5.py: 18 tasks, DEFAULT_MATRIX = "v5"; v4, v3 and v2 stay
  addressable so an earlier report reproduces exactly rather than being only
  described. mech_assembly is roadmap criterion 3 - a flange-coupling sheet
  built from the part model and the sheet standard, through the code the
  tools call (apply_titleblock, draw_part/add_view/dimension_part,
  insert_std_part, extract_records -> draw_bom_table, add_balloon), gated on
  two numbers that cannot be negotiated: drawing_critique(focus=None) returns
  zero issues and the finalize score is at least 90 (it scores 100, 18/18 on
  the v5 matrix). The adapter returns the focuses that fired, so a
  regression names itself, and a test drops one balloon to prove the gate
  fails and names mech_bom_balloon_mismatch.
- Seven correctness checks (32 -> 39). mech_section_hatch_area is the one
  that cannot be faked: a sleeve of length 60, outside diameter 40 and bore
  20 cuts two faces totalling 1200 mm^2 exactly, read back out of the drawing
  through entity_measure. sheet_frame_iso5457_a3 pins the A3 frame (20,10 to
  410,287 inside the 420 x 297 trimmed sheet); mech_iso286_on_dimension pins
  40 H7 at +0.025/0 through the layout; std_part_iso4014_m12 pins s = 18 and
  k = 7.5 by value; mech_thread_unrepresented_is_caught is the seventh: a
  quality gate that never fires is not a gate.
- scripts/smoke_mech_com.py executed every new COM path once on AutoCAD 2026
  (25.1s): frame, title block, a sectioned shaft with 12 dimensions, an ISO
  4014 block with 1 ACADMCP_MECH chunk, a weld symbol, the parts list read off
  the drawing, a linked balloon, an xref attached / listed / detached, a
  31687-byte .dwg (AC1032) through ActiveX SaveAs, critique 0 issues, exit 0,
  every scratch document closed. It retries RPC_E_CALL_REJECTED (measured:
  the first call after Documents.Add is refused) and tracks its documents by
  the document list, since SaveAs renames them.
- Defects the evidence found, each fixed with a test that fails on the old
  code:
  * ezdxf dimension_diameter put the text beyond the SECOND chord point;
    ActiveX AddDimDiametric puts it beyond the first (measured live: a d50
    from (x,170) to (x,220), leader 10, text at (x,160)). Headlessly every
    front-view diameter stood on its own chain dimension. ezdxf now follows
    ActiveX.
  * draw_part's anchor goes on MECH; ActiveX refuses entity.Layer on a
    missing layer (measured -0x7ffdfff7 'Key not found'). draw.py ensures
    every target layer before the first entity.
  * bom.extract_records filtered on INSERT; ActiveX names it BLOCKREFERENCE
    (ObjectName AcDbBlockReference) - the live parts list was empty.
  * COM _entity_info reported no dimension text_position: ModelSpace.Item
    narrows to IAcadEntity, which has no TextPosition (measured
    AttributeError); read through _com_unnarrow (TextPosition measured on
    AcDbDiametricDimension, WCS). dim_overlap compared bbox centres and a
    diameter collided with its own bore.
  * pid graph raised KeyError 'start' mid-critique on a LINE whose point read
    AutoCAD refused while busy; such a line is left out.
  * the validator read "ISO 4014 - M12x60" as fake dimension text.
- The published A/B report is re-run over the grown suite rather than
  re-typed (26/39 -> 39/39, 13 fixed, 0 regressed), check_doc_numbers derives
  the task count from the v5 matrix, the token table is remeasured with a
  TOOL_PACKS=core,mech row (193 tools / 61,673 tokens), and the README's
  collected-tests figure is retaken (3990).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd

2026-09-23 13:30:02 +03:00

Umut CANandClaude Opus 5.5

5388440c27

fix(task-7): rotation honoured end to end, each view dimensioned once, refusals that name their path

- rotation turns the whole sheet of views about `at` as one rigid body: the
  prims, the recorded WCS `bbox` (plus the sheet-frame `frame_bbox` the next
  view is laid out against), the detail marker, and every dimension intent
  (points, text position, and the linear measuring direction + rotation).
  Measured headless: rotation=90 at (100,100) now draws (70,100)-(100,172),
  records exactly that box, and leaves only the 2 diameter chord defpoints
  off-geometry (was 4, up to 47.5 mm away).
- dimension_part dimensions only views whose record is not `dimensioned`,
  takes `views=[indices]`, refuses a view already dimensioned by name
  (ISO 129-1), writes the flag back, places the hole table once, and refuses
  a fit no target view claims before drawing anything. A view the dimension
  layer emits nothing for (a detail) is reported in `skipped` and left
  unflagged. mech_dimension_part gains the `views` argument.
- draw_prims checks hatch_add_boundary's {"ok": False}: the hatch is removed
  and the failure raised, never left solid through the bore. An engine whose
  capability map says `hatch_edge_paths` is unsupported (the live one) is
  refused before any prim of the view is drawn.
- a view scale other than 1.0 is refused by name in draw_part and add_view
  (views are drawn full size; the scale would only have been recorded).
- add_view's collision step compares real rectangles on both axes and steps
  along the projection axis layout_origin chose, so a third-angle view is
  never shoved back onto the front view and a top view keeps its alignment.
- draw_from_spec validates `at` / `rotation` into the `parts[i]:` path and a
  transaction that cannot open is a ValueError (a ToolError at the tool).

No new ActiveX member is called: the change composes existing contract
members (dimension_linear rotation, entity_delete, capabilities()).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd

2026-09-23 12:20:25 +03:00

Umut CANandClaude Opus 5

8b14d4ef8d

feat(task-7): SECTION 21 - the mechanical part model as six tools

engineering/mech/draw.py is the only module in the package that touches a
backend: it turns the pure engine's primitive descriptions into entity_create_*
and dimension_* calls, places them in WCS, and writes the part model back onto
the drawing as ACADMCP_MECH XDATA on an anchor POINT. It is not a contract
member and neither are the tools - exactly like gear_draw_* and
titleblock_apply_iso_a3, it composes the generic members, so it is written once
and works on both engines by construction and no capability key is needed. No
new ActiveX call was written, so there was nothing to probe on the live seat;
measured instead that every one of the 23 backend members draw.py calls exists
on ComBackend and that ComBackend has no abstract methods left.

mech_part_draw takes one model - a turned profile or a plate outline plus typed
features - and draws its views in first-angle positions (third on request),
dimensions them and records the placement. mech_view_add reads the model back
out of the drawing and adds a side, top, section (full/half/offset/revolved) or
detail view months later without the caller re-describing the part.
mech_dimension_part lays out ISO 129 dimensions with no overlapping text,
resolves ISO 286 fits against the measured nominal, and moves the holes into a
table past a threshold. mech_hole_pattern exposes the same expansion for a
drawing that was never built from the model - with its own diameter guard,
because Hole.validate needs a part and a standalone pattern has none.
mech_part_inspect reads the payload back and never modifies the drawing.

mech_part_from_spec draws a whole sheet inside one transaction. Every part is
validated before the transaction opens, so a refusal leaves the drawing
untouched and names the path (parts[1]: segments[0].d_outer: ...), and the
rollback is shielded with the shape engineering/pid/spec.py documents: anyio
cancellation is level-triggered, so a bare await in the handler would be
cancelled before the rollback body ran and leave half a sheet inside an open
transaction.

fits goes through dimension_intents(fits=...), the API Task 6 shipped, rather
than being stamped on at draw time: that is the path that validates a key by
name and refuses a fit on a reference dimension or on a hole that moved into
the table. It is scoped per view first - a fit on segment[0] names nothing in
the end view, and refusing there would make a correct three-view sheet
undrawable - and any key no view claimed is handed back to dimension_intents so
the refusal is written in its own vocabulary.

SECTION 21 registers the six tools in the new mech pack, with alias records
(SECTIONPLANE, ARRAY plus shop-floor synonyms in English and Turkish - mil,
kademeli mil, kama, pah, kesit, gorunus), a regenerated tool inventory, the
README release snapshot at 210 tools in 24 groups, and the frozen group-size
snapshot gaining mech: 6. Lean is deliberately untouched here: spec section 11
puts three of these on the lean surface together with group G's two sheet tools,
and Task 15 makes that edit once across all four branches.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd

2026-09-22 23:17:29 +03:00