2 Commits

Include renames

Author	SHA1	Message	Date
Umut CANandClaude Opus 5	e57ae8b3ac	fix(task-12): restore the caller's tab from the layout listing; source the projection symbol ... enter_layout read the caller's space from `backend._current_space`, which only EzdxfBackend has. On ComBackend the getattr fell through to "Model", so `sheet_frame` / `titleblock_apply` with a `layout=` dropped a live caller onto the Model tab instead of putting them back -- the opposite of what the docstring and both tool docs promise, and a dual-engine parity break in new shared infrastructure. Measured on the live seat (AutoCAD 2026, scratch document from drawing_new(), closed with discard): scratch document: Drawing24.dwg layouts: ['Layout1', 'Layout2', 'Model'] B) current BEFORE: Layout2 B) the value the OLD code read (backend._current_space): <<absent -> getattr default 'Model'>> `layout_list()` already reported the right value two lines earlier on both engines (ezdxf from $TILEMODE / the active layout, COM from `doc.ActiveLayout.Name` -- read live as "Layout2" above), so `previous` now comes from `listing["current"]`. The projection-angle symbol was justified by an in-code derivation that cannot decide the question, and the test restated the implementation. The derivation was also applied inconsistently: the third-angle symbol mirrored the cone as well as the end view, leaving the trapezoid's short side pointing AWAY from the circles -- which is the first-angle arrangement. Transcribed instead from two independent reproductions of the ISO 5456-2 figure, both downloaded and measured (ISO's own figure is paywalled and was NOT read; the module says so): * FreeCAD's ISO 5457 sheet template A3_Landscape_ISO5457_advanced.svg, `first_angle_trapezoid` = "m 389,222 -10,2.5 v 5 l 10,2.5 z" -> 5-unit side at x=379, 10-unit side at x=389; circles r2.5/r5 at cx=396. * Wikimedia Commons "Convention placement vues dessin technique.svg", both symbols side by side, labelled FR and US: FR 35.856 @ x=13.343 / 66.135 @ x=81.869, circles x=148.005; US 35.856 @ x=380.275 / 66.135 @ x=448.801, circles x=314.140. Both draw the trapezoid the same way -- short side left -- and move only the end view: first angle puts it right of the cone, third angle left. Equivalently the short side points away from the circles in first angle and towards them in third, which is how every source states it in words. `third` now follows. Tests: the reference figures are transcribed into the test as data, and the symbol is asserted to land its three landmarks in the order each figure does, so the test cannot pass by agreeing with the code. The layout restore is pinned through a proxy that hides `_current_space` from the real backend rather than a fake that owns members ComBackend does not have. Both new tests fail on the previous code (measured: "assert 16.0 < 8.0" for the mirrored cone; "- SheetB + Model" for the tab). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-22 19:49:28 +03:00
Umut CANandClaude Opus 5	56e6ff7206	feat(sheet): ISO 5457 frames and ISO 7200 title blocks for A4-A0 ... SECTION 24 opens with sheet_frame and titleblock_apply. engineering/sheet/frames.py transcribes ISO 216's trimmed sizes, ISO 5457's 20 mm filing margin and 10 mm edges, the grid reference system (an even number of divisions per side, that side of the frame over 50 mm; letters from the top, numbers from the left), the centring marks (trimmed edge to 5 mm inside the frame) and the 10 x 5 mm corner trimming marks. Every one of those numbers is pinned by a test against the clause it comes from, because a wrong margin is visible on every drawing this server makes. engineering/sheet/titleblock.py draws the ISO 7200 block -- 180 mm wide, which is exactly the drawing-space width of a portrait A4, which is why one block fits every size -- and carries the ISO 128-30 projection-angle symbol. Which symbol is which is derived rather than remembered: first-angle projection puts the view seen from the left on the right, and the view of the cone from its small end is the small circle inside the large one, so first angle draws the cone left and the circles right. The old A3 module folds in. apply_iso_a3_titleblock now forwards to apply_titleblock(size="A3", projection=None, zones=False, marks=False), which is the geometry it always drew, and tests/test_engineering_titleblock.py passes unchanged -- that is the regression gate for the fold. No new ActiveX member is called: both tools reach the drawing only through contract members the A3 title block has used on both engines since v1.0 (entity_create_polyline / _line / _circle / _text, layout_list, layout_set_current), so there was nothing to probe live. Declared, not glossed: the zone divisions drawn here are equal, so ISO 5457's allowance for shorter corner fields is not implemented; the division counts, which are what a zone reference quotes, are the standard's. ISO 7200's full optional-field list is not transcribed, only the fields this block has a cell for. Coverage is A4-A0; an unknown size is refused by name with the five it has. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-22 19:03:14 +03:00