5 Commits

Include renames

Author	SHA1	Message	Date
Umut CANandClaude Opus 5	41585757c9	fix(task-2): close the trailing-newline tag hole and gate DXF-illegal layer names ... Two ways a malformed block_define request slipped past the pre-write validator and reached the engine: * `ATTDEF_TAG_RE.match` with a `$` anchor accepts 'TAG\n' because `$` matches before a trailing newline. ezdxf strips the newline on write, so 'TAG\n' + 'TAG' landed as two ATTDEFs with one tag, defeating the duplicate-tag refusal, and the tag-keyed attribute readers then dropped one silently. Now `fullmatch`. * `_layer` only required a non-empty string, so a DXF-illegal name such as 'BAD<LAYER' passed and ezdxf raised DXFValueError mid-loop, after the block existed and earlier primitives were written (with overwrite=True, after the old definition was already wiped). The gate now refuses on the same forbidden-character rule `sanitize_symbol_name` uses, exposed as `security.illegal_symbol_name_chars`, with a TypeError naming `entities[i]` and 'layer'. Tests cover both repros and fail against the previous code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd	2026-09-15 13:22:56 +03:00
Umut CANandClaude Opus 5	ca1c79fd01	fix: seven defects an adversarial audit found, and the gates that missed them ... Every one of these was reported ok/clean to the caller while being wrong. Silently wrong numbers - selection_filter(min_area) read `entity.dxf.get("area", 0.0)` for SOLID, TRACE and HATCH, none of which carry that attribute, so every hatch measured 0.0. A 1600 mm^2 hatch was excluded by min_area=1.0 while `filtered_by` asserted the filter had run, and COM (which reads ActiveX .Area) returned a different selection for the same call. It now answers from the measurement `entity_measure` uses, so the two cannot disagree. - Every headless dimension rendered through ezdxf's bare `Standard` style: 1.0 mm text with a comma decimal marker, against ISO 3098's 2.5 mm minimum and ISO 129's point -- while the document header itself said $DIMTXT 2.5. `ezdxf.new(setup=True)` is not the fix; measured, it renders a 100 mm dimension as "10000". The attributes are now stored explicitly. - Saving writes `dimrnd = 0.0` onto the Standard style, and ezdxf applies `xround(value, dimrnd)` whenever the attribute is present at all -- `xround(33.333, 0.0)` is 33. So on any reopened file, including one this server saved, every dimension was rounded to a whole unit before DIMDEC formatted it: a 12.75 mm feature dimensioned 13. AutoCAD means DIMRND 0 as *no* rounding; the sentinel is now discarded at every load site, and a real 0.5 mm rounding is left alone. - The DIM* header fold gave out-of-range values teeth they did not have when they died in the header: dim_decimals=-1 returned ok and then killed the next dimension with `ValueError: Format specifier missing precision` from inside ezdxf, and 40 printed forty digits of float noise onto the sheet. Ranges are now AutoCAD's own (DIMDEC 0-8, DIMZIN 0-15, lengths positive). Security - security.py recorded the policy as "sanitize_command and sanitize_lisp each have exactly ONE caller ... the policy is scoped to the CHANNEL". The premise was false. `_ensure_linetype_loaded` and `ComBackend.linetype_load` build `_-LINETYPE _LOAD {name} {file}` and hand it to SendCommand, which treats a newline and ';' as segment separators -- so a `linetype=` argument carrying either injected further AutoCAD commands, and the 36-verb denylist never saw that channel. Guarded with the DXF symbol-name rule (the injection characters fall out of it rather than being enumerated) plus validate_path for the file argument, which was also the one path-taking tool reaching the filesystem unchecked. The policy comment is corrected. Gates that could not see - drawing_critique returned zero issues on a quarantined document: all seven checks wrapped their backend call in a bare `except Exception`. CLAUDE.md rule 7 makes that call the gate an agent is told to trust. Only the quarantine now escapes; an ordinary broken check still degrades. `_check_dimension_legibility` also read `_doc` directly from the event loop thread, missing the gate and performing exactly the unsynchronised access the quarantine exists to prevent. `construction_clear` answered "deleted: 0" -- there was nothing to clear -- for the same reason. - The iso128 focus checked layer lineweights only, so a sheet lettered at 1.0 mm critiqued clean. It now reads the effective dimension height and separator, header-then-style, in the order the renderer resolves. - check_doc_numbers.py derived five values it never checked, and those were the ones that had drifted. The collected-test count (README said 1274, the tree had 1369) and the A/B pass-rate and Fixed columns are now gated. - benchmarks/README.md's v1.4.0 table was impossible on its face -- 21 passing plus 5 fixed is 26, not 24 -- and contradicted the report it linked, because `ab-v1.4.0-vs-v1.5.0.json` was regenerated from a tree that already carried the dimension fixes and so never measured the v1.5.0 tag. Replaced with a real run: ab-v1.4.0-vs-v1.5.1.json, 21/26 -> 26/26. Release gate - release.yml ran one ubuntu/3.11 lane, so a Windows-only defect could reach PyPI with no Windows job having executed. That is not hypothetical: v1.5.0 shipped `except pywintypes.com_error` raising NameError wherever pywin32 is absent. It now runs the same three lanes as ci.yml, Windows included. 1368 passed, 1 xfailed. ruff clean. Tool inventory and all 16 gated document numbers match the tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-06 23:07:50 +03:00
Umut CANandClaude Opus 5	b03a7615b1	release: v1.5.0 — discovery layer, honesty debt closed, Wave A ... Tool count 131 -> 154; 474 -> 1242 collected tests. The release exists for two measured reasons. A 149-tool catalog costs a client ~40,300 tokens before it has asked for anything, and a drafter searching the way drafters think -- FILLET, BPOLY, QSELECT, WBLOCK -- scored df=0 against the stock index, because those words were simply not in the data. Discovery and batching - DISCOVERY_MODE=search replaces the catalog with search_tools + call_tool, ranked over an AutoCAD command and synonym corpus (discovery/aliases.py) on top of fastmcp's BM25 index. Measured: 40,305 -> 356 tokens advertised. - cad_batch runs a step list in one round trip; fields= projects result-heavy responses. The `core` profile is gone -- discovery replaced it. Honesty debt (Tier 0) - OCS/ECS: `extrusion` appeared nowhere in this codebase, so mirrored and rotated geometry reported coordinates that were quietly wrong. backends/ocs.py translates at the backend boundary; every tool coordinate is WCS on both engines, and a tilted plane refuses rather than answering with a number that looks fine. - drawing_save_as(fmt="dwg") wrote DXF bytes to a .dwg path. drawing_audit never repaired. analysis_measure_area shoelaced points the caller typed in. - ezdxf calls gained a per-call timeout, so one hung call can no longer wedge a server whose document lock is a single asyncio.Lock. Architecture - The 1854-line backend ABC is 19 contract modules; @capability(key, reason=) makes optional methods declarative and a gate fails on undeclared holes. - 8 layout/viewport tools, CHSPACE, CAD_PROGID escape hatch. - Wave A: selection filters, boundary tracing, hatch depth, annotation objects, measurement -- 13 tools of a planned 39. The REGION and 2D-boolean family was cut on evidence: add_region() yields zero ACIS bytes and the greiner_hormann substitute loses 28.2% of the area on a square with one semicircular edge. Verified against a live AutoCAD 2026, which found four COM defects no amount of reading would have caught -- AcadPViewport has no ViewCenter, and the line that set it had been swallowed by a bare except since v1.4. Benchmark v3 (15 tasks) and what it caught - v2 scored this server 10/10, which carried no information: every task in it exercised something the server was built around. Five tasks were added because they can fail, and three did while being written -- a hatch could not be measured though the refusal listed HATCH as measurable, the boundary tools and the measure tool disagreed about the same shape (139.2177 vs 139.2699), and a circle stored as two bulged vertices measured 0.0. - Competitor reports are NOT re-scored. They are pinned v1.4 runs against v2 and were never asked these five questions; the chart shows those rows `not run`. - Correctness A/B: 21/24 -> 24/24, zero regressions. Performance, stated plainly The published v1.4 perf report was recorded on CPython 3.14 and the new one on 3.11.15, so the apparent 2-6x speedup is the interpreter, not this release. Re-measured on one interpreter, v1.5.0 is 28% slower creating entities and 22% slower on the 10k roundtrip. Fully attributed: EZDXF_CALL_TIMEOUT=0 restores v1.4.0's exact numbers. That is the deadlock fix being paid for, the knob is documented, and winning it back is on the 1.6 roadmap. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-06 09:45:20 +03:00
Umutcan EdizsalanandCursor	9ec6c4a989	style: apply ruff format across the repository ... ruff format was never run repo-wide; CI now enforces 'ruff format --check', so normalize every module once. No behavior changes. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-07-23 15:14:51 +03:00
U-C4N	7b121ab416	Initial commit	2026-04-27 12:20:57 +03:00