feat(pid): pid_from_spec — a whole P&ID in one transaction, graph and critique returned

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd

tests/test_pid_from_spec.py

@@ -0,0 +1,87 @@
+"""pid_from_spec: one call, one transaction, graph + critique back."""
+
+from __future__ import annotations
+
+import copy
+
+import pytest
+import pytest_asyncio
+from fastmcp import Client
+
+import server
+from engineering.pid.spec import EXAMPLE_SPEC, run_spec, validate_spec
+
+pytestmark = pytest.mark.asyncio
+
+
+async def test_example_draws_a_connected_pid(backend):
+    result = await run_spec(backend, EXAMPLE_SPEC)
+    assert set(result["handles"]) == {"P-101", "V-201", "FCV-101", "FIC-101", "OP-1"}
+    graph = result["graph"]
+    assert graph["stats"]["nodes_by_kind"] == {
+        "connector": 1,
+        "equipment": 2,
+        "instrument": 1,
+        "valve": 1,
+    }
+    assert len(graph["edges"]) == 4 and graph["stats"]["dangling"] == 0
+    assert result["critique"] == [] and result["crossings_total"] == 0
+    assert backend.get_plan_spec()["layer_set_id"] == "pid"
+
+
+async def test_bad_reference_rolls_back(backend):
+    before = await backend.entity_count()
+    bad = copy.deepcopy(EXAMPLE_SPEC)
+    bad["lines"].append({"from": "P-101.discharge", "to": "V-201.NOPE", "class": "process_major"})
+    with pytest.raises(ValueError, match=r"lines\[3\]"):
+        await run_spec(backend, bad)
+    assert await backend.entity_count() == before
+
+
+async def test_dry_run_routes_in_memory_and_writes_nothing(backend):
+    before = await backend.entity_count()
+    result = await run_spec(backend, EXAMPLE_SPEC, dry_run=True)
+    assert result["dry_run"] is True and len(result["lines"]) == 4
+    assert all(len(line["vertices"]) >= 2 for line in result["lines"])
+    assert await backend.entity_count() == before
+
+
+@pytest.mark.parametrize(
+    "mutate, fragment",
+    [
+        (
+            lambda s: s["equipment"].append({"id": "P-101", "symbol": "fan", "x": 0, "y": 0}),
+            "equipment[2].id",
+        ),
+        (lambda s: s["lines"][0].update({"class": "steam"}), "lines[0].class"),
+        (lambda s: s["instruments"][0].pop("x"), "instruments[0].x"),
+        (lambda s: s.update({"bogus": []}), "bogus"),
+        (lambda s: s["connectors"][0].update({"to": "V-201.N1"}), "connectors[0]"),
+    ],
+)
+async def test_validation_names_the_path(mutate, fragment):
+    spec = copy.deepcopy(EXAMPLE_SPEC)
+    mutate(spec)
+    with pytest.raises(ValueError) as exc:
+        validate_spec(spec)
+    assert fragment in str(exc.value)
+
+
+@pytest_asyncio.fixture
+async def client(monkeypatch):
+    monkeypatch.setenv("AUTOCAD_MCP_BACKEND", "ezdxf")
+    async with Client(server.mcp) as connected:
+        await connected.call_tool("drawing_new", {})
+        yield connected
+
+
+async def test_finalize_scores_the_example_at_ninety_or_better(client, tmp_path):
+    result = (await client.call_tool("pid_from_spec", {"spec": EXAMPLE_SPEC})).structured_content
+    assert result["graph"]["stats"]["dangling"] == 0
+    # The validator's first step refuses an unsaved drawing (`not_saved`), so
+    # finalize saves first — the same shape `tests/test_pid_critique.py` uses.
+    final = (
+        await client.call_tool("drawing_finalize", {"save_path": str(tmp_path / "pid.dxf")})
+    ).structured_content
+    assert final["score"]["score"] >= 90, final["score"]
+    assert not [i for i in final.get("critique", []) if str(i.get("focus", "")).startswith("pid_")]

tests/test_tool_registry.py

@@ -512,8 +512,9 @@ async def test_tool_group_sizes_are_unchanged():
     `pid_symbol_insert`, then 2 -> 3 when `pid_line_draw` joined, 3 -> 4
     when the reader `pid_graph` joined and 4 -> 7 when the three graph
     deliverables (`pid_instrument_index` / `pid_line_list` /
-    `pid_equipment_list`) joined; the `pid` tag is ranked first in
-    `_GROUP_TAG_PRIORITY` so those tools file under
+    `pid_equipment_list`) joined and 7 -> 8 when `pid_from_spec` (a whole
+    sheet from one declarative spec, in one transaction) joined; the `pid`
+    tag is ranked first in `_GROUP_TAG_PRIORITY` so those tools file under
     `pid` rather than under their secondary `query` / `create` tags. Every
     other number here has been unchanged since the snapshot was taken.
     """
@@ -531,7 +532,7 @@ async def test_tool_group_sizes_are_unchanged():
         "entity_query": 9,
         "layers": 14,
         "layouts": 12,
-        "pid": 7,
+        "pid": 8,
         "premium": 12,
         "solids": 5,
         "system": 7,
@@ -540,4 +541,4 @@ async def test_tool_group_sizes_are_unchanged():
         "validation": 1,
         "view": 4,
     }
-    assert sum(sizes.values()) == 164
+    assert sum(sizes.values()) == 165