fix: seven defects an adversarial audit found, and the gates that missed them
Release / test (full, windows-latest, 3.11) (push) Canceled after 0s
Release / test (pdf, ubuntu-latest, 3.11) (push) Canceled after 0s
Release / test (pdf, ubuntu-latest, 3.12) (push) Canceled after 0s
Release / build (push) Canceled after 0s
Release / publish-pypi (push) Canceled after 0s
Release / github-release (push) Canceled after 0s
Release / test (full, windows-latest, 3.11) (push) Canceled after 0s
Release / test (pdf, ubuntu-latest, 3.11) (push) Canceled after 0s
Release / test (pdf, ubuntu-latest, 3.12) (push) Canceled after 0s
Release / build (push) Canceled after 0s
Release / publish-pypi (push) Canceled after 0s
Release / github-release (push) Canceled after 0s
Every one of these was reported ok/clean to the caller while being wrong.
Silently wrong numbers
- selection_filter(min_area) read `entity.dxf.get("area", 0.0)` for SOLID,
TRACE and HATCH, none of which carry that attribute, so every hatch
measured 0.0. A 1600 mm^2 hatch was excluded by min_area=1.0 while
`filtered_by` asserted the filter had run, and COM (which reads ActiveX
.Area) returned a different selection for the same call. It now answers
from the measurement `entity_measure` uses, so the two cannot disagree.
- Every headless dimension rendered through ezdxf's bare `Standard` style:
1.0 mm text with a comma decimal marker, against ISO 3098's 2.5 mm minimum
and ISO 129's point -- while the document header itself said $DIMTXT 2.5.
`ezdxf.new(setup=True)` is not the fix; measured, it renders a 100 mm
dimension as "10000". The attributes are now stored explicitly.
- Saving writes `dimrnd = 0.0` onto the Standard style, and ezdxf applies
`xround(value, dimrnd)` whenever the attribute is present at all --
`xround(33.333, 0.0)` is 33. So on any reopened file, including one this
server saved, every dimension was rounded to a whole unit before DIMDEC
formatted it: a 12.75 mm feature dimensioned 13. AutoCAD means DIMRND 0 as
*no* rounding; the sentinel is now discarded at every load site, and a real
0.5 mm rounding is left alone.
- The DIM* header fold gave out-of-range values teeth they did not have when
they died in the header: dim_decimals=-1 returned ok and then killed the
next dimension with `ValueError: Format specifier missing precision` from
inside ezdxf, and 40 printed forty digits of float noise onto the sheet.
Ranges are now AutoCAD's own (DIMDEC 0-8, DIMZIN 0-15, lengths positive).
Security
- security.py recorded the policy as "sanitize_command and sanitize_lisp each
have exactly ONE caller ... the policy is scoped to the CHANNEL". The
premise was false. `_ensure_linetype_loaded` and `ComBackend.linetype_load`
build `_-LINETYPE _LOAD {name} {file}` and hand it to SendCommand, which
treats a newline and ';' as segment separators -- so a `linetype=` argument
carrying either injected further AutoCAD commands, and the 36-verb denylist
never saw that channel. Guarded with the DXF symbol-name rule (the
injection characters fall out of it rather than being enumerated) plus
validate_path for the file argument, which was also the one path-taking
tool reaching the filesystem unchecked. The policy comment is corrected.
Gates that could not see
- drawing_critique returned zero issues on a quarantined document: all seven
checks wrapped their backend call in a bare `except Exception`. CLAUDE.md
rule 7 makes that call the gate an agent is told to trust. Only the
quarantine now escapes; an ordinary broken check still degrades.
`_check_dimension_legibility` also read `_doc` directly from the event loop
thread, missing the gate and performing exactly the unsynchronised access
the quarantine exists to prevent. `construction_clear` answered
"deleted: 0" -- there was nothing to clear -- for the same reason.
- The iso128 focus checked layer lineweights only, so a sheet lettered at
1.0 mm critiqued clean. It now reads the effective dimension height and
separator, header-then-style, in the order the renderer resolves.
- check_doc_numbers.py derived five values it never checked, and those were
the ones that had drifted. The collected-test count (README said 1274, the
tree had 1369) and the A/B pass-rate and Fixed columns are now gated.
- benchmarks/README.md's v1.4.0 table was impossible on its face -- 21
passing plus 5 fixed is 26, not 24 -- and contradicted the report it
linked, because `ab-v1.4.0-vs-v1.5.0.json` was regenerated from a tree that
already carried the dimension fixes and so never measured the v1.5.0 tag.
Replaced with a real run: ab-v1.4.0-vs-v1.5.1.json, 21/26 -> 26/26.
Release gate
- release.yml ran one ubuntu/3.11 lane, so a Windows-only defect could reach
PyPI with no Windows job having executed. That is not hypothetical: v1.5.0
shipped `except pywintypes.com_error` raising NameError wherever pywin32 is
absent. It now runs the same three lanes as ci.yml, Windows included.
1368 passed, 1 xfailed. ruff clean. Tool inventory and all 16 gated document
numbers match the tree.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
6b9860e68e
commit
ca1c79fd01
@@ -130,10 +130,86 @@ async def test_the_default_dimscale_adds_no_override(backend):
|
||||
|
||||
|
||||
async def test_dimscale_reaches_aligned_and_angular_too(backend):
|
||||
"""Those two do not go through `build_dim_override`, so they were missed."""
|
||||
await backend.drawing_settings({"dimscale": 3.0})
|
||||
aligned = await backend.dimension_aligned(0, 0, 60, 60, 40, 70)
|
||||
angular = await backend.dimension_angular(0, 0, 50, 0, 0, 50, 30, 30)
|
||||
"""Those two do not go through `build_dim_override`, so they were missed.
|
||||
|
||||
for handle in (aligned.handle, angular.handle):
|
||||
assert _dim_text_heights(backend, handle) == pytest.approx([3.0])
|
||||
Asserted as a *ratio* against the same dimension drawn unscaled. This used
|
||||
to hardcode 3.0, which only held because the base text height was ezdxf's
|
||||
bare 1.0 mm — so the assertion silently depended on the very defect that
|
||||
made every headless drawing non-conformant, and moving the base to the ISO
|
||||
2.5 mm broke a test that was measuring the right thing by accident.
|
||||
"""
|
||||
plain_aligned = await backend.dimension_aligned(0, 0, 60, 60, 40, 70)
|
||||
plain_angular = await backend.dimension_angular(0, 0, 50, 0, 0, 50, 30, 30)
|
||||
base_aligned = _dim_text_heights(backend, plain_aligned.handle)
|
||||
base_angular = _dim_text_heights(backend, plain_angular.handle)
|
||||
|
||||
await backend.drawing_settings({"dimscale": 3.0})
|
||||
aligned = await backend.dimension_aligned(0, 0, 60, 60, 40, 90)
|
||||
angular = await backend.dimension_angular(0, 0, 50, 0, 0, 50, 50, 50)
|
||||
|
||||
assert _dim_text_heights(backend, aligned.handle) == pytest.approx(
|
||||
[h * 3.0 for h in base_aligned]
|
||||
)
|
||||
assert _dim_text_heights(backend, angular.handle) == pytest.approx(
|
||||
[h * 3.0 for h in base_angular]
|
||||
)
|
||||
|
||||
|
||||
# ── the rest of the dimension variables need friendly names too ─────────────
|
||||
|
||||
|
||||
def _dim_text(backend, handle) -> str:
|
||||
dim = backend._doc.entitydb.get(handle)
|
||||
for entity in backend._doc.blocks.get(dim.dxf.geometry):
|
||||
if entity.dxftype() == "MTEXT":
|
||||
return entity.text
|
||||
if entity.dxftype() == "TEXT":
|
||||
return entity.dxf.text
|
||||
raise AssertionError("the dimension block carries no text")
|
||||
|
||||
|
||||
async def test_the_dimension_variables_have_friendly_names(backend):
|
||||
"""DIMTXT / DIMASZ / DIMDEC / DIMDSEP / DIMZIN had no friendly key at all.
|
||||
|
||||
`text_size` is TEXTSIZE — the height of a standalone TEXT entity, not of a
|
||||
dimension — so the only way to reach dimension lettering was raw
|
||||
`system_set_variable`, which is exactly the path that silently did nothing
|
||||
headlessly. A drafter should not have to know a sysvar name to set the
|
||||
height of the numbers on their own drawing.
|
||||
"""
|
||||
res = await backend.drawing_settings(
|
||||
{
|
||||
"dim_text_height": 5.0,
|
||||
"dim_arrow_size": 6.0,
|
||||
"dim_decimals": 1,
|
||||
"decimal_separator": ",",
|
||||
"zero_suppression": 0,
|
||||
}
|
||||
)
|
||||
assert res["ok"] is True, res.get("errors")
|
||||
|
||||
dim = await backend.dimension_linear(0, 0, 33.333, 0, 16, -30)
|
||||
assert _dim_text(backend, dim.handle) == "33,3"
|
||||
assert _dim_text_heights(backend, dim.handle) == pytest.approx([5.0])
|
||||
|
||||
|
||||
async def test_the_decimal_separator_reads_back_as_a_character(backend):
|
||||
"""DIMDSEP is an int char code in the header — ezdxf refuses a string
|
||||
there. The friendly key is the place to translate, so a snapshot says
|
||||
',' rather than 44."""
|
||||
await backend.drawing_settings({"decimal_separator": ","})
|
||||
|
||||
snap = (await backend.drawing_settings())["settings"]
|
||||
|
||||
assert snap["decimal_separator"] == ","
|
||||
assert snap["dim_text_height"] == 2.5
|
||||
|
||||
|
||||
async def test_a_bad_decimal_separator_is_reported_and_not_written(backend):
|
||||
before = await backend.system_get_variable("DIMDSEP")
|
||||
|
||||
res = await backend.drawing_settings({"decimal_separator": "x"})
|
||||
|
||||
assert "decimal_separator" in res["errors"]
|
||||
assert res["ok"] is False
|
||||
assert await backend.system_get_variable("DIMDSEP") == before
|
||||
|
||||
Reference in New Issue
Block a user