feat(templates): five bundled templates built by the server's own tools; drawing_new(template=name)

SECTION 19 grows to five tools with drawing_template_list; drawing_new takes a bundled name (iso_a3_mech, iso_a1_arch, iso_a3_pid, ansi_b_mech, ansi_d_arch) or a .dwt/.dxf path and reports template: {name|path, path, source}. scripts/build_templates.py builds templates/*.dxf through EzdxfBackend (layer set, header DIM variables until group S's styles land, drawing_settings, sheet tab, ISO 5457 frame on A3, page_setup_apply) and --check pins them reproducible. One drift the plan's same-process measurement could not see is fixed at the source rather than masked: ezdxf orders CLASSES by set iteration, so two processes disagreed on LAYOUT / ACDBPLACEHOLDER; the section is re-keyed (required list first, then by name) before the save. The root .gitignore ignores *.dxf as generated output; templates/*.dxf is un-ignored there, since the bundled set is the one DXF that is committed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd
2026-09-21 22:03:41 +03:00
parent 86c5d6ad65
commit a76d9e08a3
17 changed files with 19981 additions and 22 deletions
@@ -0,0 +1,187 @@
+"""Bundled templates: catalogue, resolution, reproducible build, drawing_new(template=)."""
+
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+
+import pytest
+from fastmcp.exceptions import ToolError
+
+import server
+from engineering.standards.templates import (
+    TEMPLATE_CATALOG,
+    TEMPLATES_DIR,
+    resolve_template,
+    template_rows,
+)
+
+pytestmark = pytest.mark.asyncio
+
+ROOT = Path(__file__).resolve().parents[1]
+NAMES = ("iso_a3_mech", "iso_a1_arch", "iso_a3_pid", "ansi_b_mech", "ansi_d_arch")
+
+
+def _build_module():
+    spec = importlib.util.spec_from_file_location(
+        "build_templates", ROOT / "scripts" / "build_templates.py"
+    )
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+class _Ctx:
+    def __init__(self, backend):
+        self.lifespan_context = {"backend": backend}
+
+    async def info(self, message):
+        pass
+
+    async def warning(self, message):
+        pass
+
+    async def report_progress(self, progress, total):
+        pass
+
+
+# ── catalogue ───────────────────────────────────────────────────────────────
+
+
+def test_catalog_has_the_five_spec_rows():
+    assert tuple(TEMPLATE_CATALOG) == NAMES
+    rows = {spec.name: spec for spec in TEMPLATE_CATALOG.values()}
+    assert (rows["iso_a3_mech"].paper, rows["iso_a3_mech"].layer_set) == ("ISO_A3", "mech")
+    assert (rows["iso_a1_arch"].paper, rows["iso_a1_arch"].layer_set) == ("ISO_A1", "iso13567")
+    assert rows["iso_a1_arch"].settings["annotation_scale"] == "1:50"
+    assert (rows["iso_a3_pid"].paper, rows["iso_a3_pid"].layer_set) == ("ISO_A3", "pid")
+    assert (rows["ansi_b_mech"].paper, rows["ansi_b_mech"].dimstyle) == ("ANSI_B", "ANSI")
+    assert (rows["ansi_d_arch"].paper, rows["ansi_d_arch"].scale) == ("ANSI_D", "fit")
+    assert [spec.title_block for spec in TEMPLATE_CATALOG.values()] == [
+        True,
+        False,
+        True,
+        False,
+        False,
+    ]
+    assert all(spec.orientation == "landscape" for spec in TEMPLATE_CATALOG.values())
+    assert {spec.textstyle for spec in TEMPLATE_CATALOG.values()} == {"ISOCP", "ROMANS"}
+
+
+def test_template_rows_report_files():
+    rows = template_rows()
+    assert [row["name"] for row in rows] == list(NAMES)
+    for row in rows:
+        assert set(row["files"]) == {"dxf", "dwt"}
+        assert row["files"]["dxf"]["path"].endswith(f"{row['name']}.dxf")
+        assert isinstance(row["files"]["dxf"]["present"], bool)
+
+
+def test_resolve_template_bundled_path_and_unknown(tmp_path):
+    path, source = resolve_template("iso_a3_mech", "ezdxf")
+    assert source == "bundled" and path == str(TEMPLATES_DIR / "iso_a3_mech.dxf")
+    path, source = resolve_template("ISO_A3_MECH", "ezdxf")
+    assert source == "bundled"
+    # COM prefers the .dwt twin and says when it fell back to the DXF
+    path, source = resolve_template("iso_a3_mech", "com")
+    assert source in ("bundled", "bundled_dxf")
+    assert path.endswith(".dwt" if source == "bundled" else ".dxf")
+    explicit = tmp_path / "mine.dwt"
+    assert resolve_template(str(explicit), "ezdxf") == (str(explicit), "path")
+    assert resolve_template("sheet.dxf", "com") == ("sheet.dxf", "path")
+    with pytest.raises(
+        ValueError, match="iso_a3_mech, iso_a1_arch, iso_a3_pid, ansi_b_mech, ansi_d_arch"
+    ):
+        resolve_template("iso_a2_mech", "ezdxf")
+    with pytest.raises(ValueError, match="template"):
+        resolve_template("", "ezdxf")
+
+
+# ── the build ───────────────────────────────────────────────────────────────
+
+
+async def test_build_is_deterministic_run_to_run(tmp_path):
+    build = _build_module()
+    first = await build.build_all(tmp_path / "one")
+    second = await build.build_all(tmp_path / "two")
+    assert [row["name"] for row in first] == list(NAMES)
+    for name in NAMES:
+        a = build.normalised_lines(tmp_path / "one" / f"{name}.dxf")
+        b = build.normalised_lines(tmp_path / "two" / f"{name}.dxf")
+        assert a == b, f"{name} differs between two builds"
+    assert all(row["page_setup"]["ok"] for row in first)
+    assert all(row["layers"] for row in first)
+    assert second  # the second build is only there to be compared with the first
+
+
+async def test_committed_templates_match_a_fresh_build(tmp_path):
+    """The spec's reproducibility claim — the same comparison the script's --check runs."""
+    build = _build_module()
+    missing = [name for name in NAMES if not (TEMPLATES_DIR / f"{name}.dxf").is_file()]
+    assert not missing, f"bundled templates missing: {missing} — run scripts/build_templates.py"
+    await build.build_all(tmp_path)
+    drifted = build.drifted_names(tmp_path)
+    assert drifted == [], f"templates drifted from the script: {drifted}"
+
+
+# ── drawing_new(template=) ──────────────────────────────────────────────────
+
+
+async def test_drawing_new_from_a_bundled_template(backend):
+    result = await server.drawing_new(template="iso_a3_mech", ctx=_Ctx(backend))
+    assert result["ok"] is True
+    assert result["template"] == {
+        "name": "iso_a3_mech",
+        "path": str(TEMPLATES_DIR / "iso_a3_mech.dxf"),
+        "source": "bundled",
+    }
+    layers = {layer.name for layer in await backend.layer_list()}
+    assert {"GEOMETRY", "DIM", "HIDDEN", "CENTER", "TITLEBLOCK"} <= layers
+    row = (await backend.page_setup_list("A3"))[0]
+    assert row["paper"] == "ISO_A3" and row["orientation"] == "landscape"
+    assert row["plot_style"] == "monochrome.ctb" and row["scale"] == "1:1"
+    sheet = backend._doc.layouts.get("A3")
+    assert any(e.dxftype() == "LWPOLYLINE" for e in sheet), "the ISO 5457 frame is on the sheet"
+    assert float(await backend.system_get_variable("DIMTXT")) == 2.5
+    if hasattr(backend, "dimstyle_create"):  # after group S merges
+        assert await backend.system_get_variable("DIMSTYLE") == "ISO-25"
+
+
+async def test_drawing_new_from_the_pid_and_ansi_templates(backend):
+    await server.drawing_new(template="iso_a3_pid", ctx=_Ctx(backend))
+    assert "PROCESS-PIPING-MAIN" in {layer.name for layer in await backend.layer_list()}
+    await server.drawing_new(template="ansi_d_arch", ctx=_Ctx(backend))
+    assert "M-GEOMET-E-N" in {layer.name for layer in await backend.layer_list()}
+    row = (await backend.page_setup_list("D"))[0]
+    assert row["paper"] == "ANSI_D" and row["size_mm"] == [864.0, 559.0] and row["scale"] == "fit"
+    assert (await backend.drawing_settings())["settings"]["decimal_separator"] == "."
+
+
+async def test_drawing_new_unknown_template_is_refused_with_the_names(backend):
+    await backend.entity_create_line(0, 0, 1, 1)
+    before = (await backend.drawing_info()).entity_count
+    with pytest.raises(ToolError, match="iso_a3_mech"):
+        await server.drawing_new(template="iso_a2_mech", ctx=_Ctx(backend))
+    assert (await backend.drawing_info()).entity_count == before, "the refusal replaced nothing"
+
+
+async def test_drawing_new_missing_template_path_is_refused(backend, tmp_path):
+    with pytest.raises(ToolError, match="not found"):
+        await server.drawing_new(template=str(tmp_path / "gone.dxf"), ctx=_Ctx(backend))
+
+
+async def test_drawing_new_from_an_explicit_dxf_path_reports_source_path(backend, tmp_path):
+    await backend.layer_create("MINE", color=3)
+    saved = tmp_path / "mine.dxf"
+    await backend.drawing_save_as(str(saved), "dxf")
+    result = await server.drawing_new(template=str(saved), ctx=_Ctx(backend))
+    assert result["template"]["source"] == "path"
+    assert result["template"]["path"] == str(saved.resolve())
+    assert "MINE" in {layer.name for layer in await backend.layer_list()}
+
+
+async def test_drawing_template_list_tool(backend):
+    result = await server.drawing_template_list(ctx=_Ctx(backend))
+    assert result["ok"] and result["count"] == 5
+    assert [row["name"] for row in result["templates"]] == list(NAMES)
+    assert result["engine"] == "ezdxf"