fix(blocks): block_define refuses a non-finite base point and a missing layer unless create_layers

base_x/base_y were only float()-cast, so a NaN base point was written into
the BLOCK record; a primitive on a layer the drawing lacks was written as a
dangling reference doc.audit() never flags (and on COM would fail mid-loop
after Blocks.Add). validate_base_point names the key; the layer table is
probed before the first write and the missing names are refused, or created
and reported as layers_created when create_layers=true (new optional kwarg,
contract + both engines + tool).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FKFStjEFzpGyLq5bMpWxTd

tests/test_block_define.py

@@ -34,6 +34,7 @@ async def test_defines_geometry_and_attdefs(backend):
         "entity_count": 7,
         "attdef_count": 2,
         "replaced": False,
+        "layers_created": [],
         "backend": "ezdxf",
     }
     blk = backend._doc.blocks.get("PID_VALVE_TEST")

tests/test_track_a_hardening.py

@@ -1589,3 +1589,72 @@ async def test_com_set_attributes_refuses_before_touching_the_reference(com):
         "updated_tags": ["TAG"],
     }
     assert attr.TextString == "2.5"
+
+
+# ── Task 4: block_define validates the base point and the layer table ────────
+
+CIRC = [{"type": "circle", "cx": 0, "cy": 0, "r": 1}]
+ON_LAYER = [{"type": "line", "x1": 0, "y1": 0, "x2": 1, "y2": 1, "layer": "NOT_A_LAYER"}]
+
+
+@pytest.mark.parametrize(
+    "kwargs, key",
+    [
+        ({"base_x": float("nan")}, "base_x"),
+        ({"base_y": float("inf")}, "base_y"),
+        ({"base_x": "3"}, "base_x"),
+        ({"base_y": True}, "base_y"),
+        ({"base_x": 10**400}, "base_x"),
+    ],
+)
+async def test_define_refuses_a_bad_base_point_before_writing(backend, kwargs, key):
+    with pytest.raises(TypeError, match=f"'{key}'"):
+        await backend.block_define("PID_BASE", CIRC, **kwargs)
+    assert "PID_BASE" not in backend._doc.blocks
+
+
+async def test_define_refuses_a_missing_layer_and_names_it(backend):
+    with pytest.raises(ValueError, match="'NOT_A_LAYER' do not exist") as exc:
+        await backend.block_define("PID_LYR", ON_LAYER)
+    assert "create_layers=true" in str(exc.value)
+    assert "PID_LYR" not in backend._doc.blocks
+    assert "NOT_A_LAYER" not in backend._doc.layers
+
+
+async def test_define_creates_the_layer_on_request_and_reports_it(backend):
+    result = await backend.block_define("PID_LYR", ON_LAYER, create_layers=True)
+    assert result["layers_created"] == ["NOT_A_LAYER"] and result["ok"] is True
+    assert "NOT_A_LAYER" in backend._doc.layers
+    member = next(iter(backend._doc.blocks.get("PID_LYR")))
+    assert member.dxf.layer == "NOT_A_LAYER"
+
+
+async def test_define_on_an_existing_layer_reports_nothing_created(backend):
+    await backend.layer_create("PID-EQUIP")
+    spec = [{**ON_LAYER[0], "layer": "PID-EQUIP"}]
+    result = await backend.block_define("PID_OK", spec)
+    assert result["layers_created"] == []
+    result = await backend.block_define("PID_ZERO", CIRC)
+    assert result["layers_created"] == [], "layer 0 always exists"
+
+
+async def test_com_define_probes_layers_before_blocks_add(com):
+    backend, document, space = com
+    with pytest.raises(ValueError, match="'NOT_A_LAYER' do not exist"):
+        await backend.block_define("PID_LYR", ON_LAYER)
+    assert "PID_LYR" not in document.Blocks.blocks and document.Layers.added == []
+
+    result = await backend.block_define("PID_LYR", ON_LAYER, create_layers=True)
+    assert result["layers_created"] == ["NOT_A_LAYER"] and result["backend"] == "com"
+    assert document.Layers.added == ["NOT_A_LAYER"]
+    assert [name for name, _ in document.Blocks.blocks["PID_LYR"].calls] == ["AddLine"]
+
+
+async def test_com_define_refuses_a_bad_base_point_before_blocks_add(com):
+    backend, document, space = com
+    with pytest.raises(TypeError, match="'base_y'"):
+        await backend.block_define("PID_BASE", CIRC, base_y=float("nan"))
+    assert "PID_BASE" not in document.Blocks.blocks
+    result = await backend.block_define("PID_BASE", CIRC, base_x=1.5, base_y=2.5)
+    assert document.Blocks.blocks["PID_BASE"].base_point == (1.5, 2.5, 0.0)
+    assert result["layers_created"] == []